Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1869)

Side by Side Diff: chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/json/json_reader.h" 8 #include "base/json/json_reader.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/test/chromedriver/chrome/navigation_tracker.h" 10 #include "chrome/test/chromedriver/chrome/navigation_tracker.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 private: 166 private:
167 bool is_loading_; 167 bool is_loading_;
168 std::string send_event_first_; 168 std::string send_event_first_;
169 base::DictionaryValue* send_event_first_params_; 169 base::DictionaryValue* send_event_first_params_;
170 }; 170 };
171 171
172 } // namespace 172 } // namespace
173 173
174 TEST(NavigationTracker, UnknownStateForcesStart) { 174 TEST(NavigationTracker, UnknownStateForcesStart) {
175 base::DictionaryValue params; 175 base::DictionaryValue params;
176 DeterminingLoadStateDevToolsClient client(true, "", &params); 176 DeterminingLoadStateDevToolsClient client(true, std::string(), &params);
177 NavigationTracker tracker(&client); 177 NavigationTracker tracker(&client);
178 ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", true)); 178 ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", true));
179 } 179 }
180 180
181 TEST(NavigationTracker, UnknownStateForcesStartReceivesStop) { 181 TEST(NavigationTracker, UnknownStateForcesStartReceivesStop) {
182 base::DictionaryValue params; 182 base::DictionaryValue params;
183 DeterminingLoadStateDevToolsClient client( 183 DeterminingLoadStateDevToolsClient client(
184 true, "Page.frameStoppedLoading", &params); 184 true, "Page.frameStoppedLoading", &params);
185 NavigationTracker tracker(&client); 185 NavigationTracker tracker(&client);
186 ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", false)); 186 ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", false));
187 } 187 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc ('k') | chrome/test/chromedriver/chrome/stub_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698