Rewrite std::string("") to std::string(), Linux edition.

chrome/common/json_schema/json_schema_validator_unittest_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/json_schema/json_schema_validator_unittest_base.h"
 
 #include <cfloat>
 #include <cmath>
 #include <limits>
 
@@ skipping 112 matching lines @@
   schema->SetString(schema::kPattern, "foo+");
 
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::StringValue("foo")).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::StringValue("foooooo")).get(),
               schema.get(), NULL);
   ExpectNotValid(TEST_SOURCE,
                  scoped_ptr<base::Value>(new base::StringValue("bar")).get(),
-                 schema.get(), NULL, "",
+                 schema.get(),
+                 NULL,
+                 std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kStringPattern, "foo+"));
 }
 
 void JSONSchemaValidatorTestBase::TestEnum() {
   scoped_ptr<base::DictionaryValue> schema(LoadDictionary("enum_schema.json"));
 
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::StringValue("foo")).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(false)).get(),
               schema.get(), NULL);
 
   ExpectNotValid(TEST_SOURCE,
                  scoped_ptr<base::Value>(new base::StringValue("42")).get(),
-                 schema.get(), NULL, "", JSONSchemaValidator::kInvalidEnum);
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::kInvalidEnum);
   ExpectNotValid(TEST_SOURCE,
                  scoped_ptr<base::Value>(base::Value::CreateNullValue()).get(),
-                 schema.get(), NULL, "", JSONSchemaValidator::kInvalidEnum);
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::kInvalidEnum);
 }
 
 void JSONSchemaValidatorTestBase::TestChoices() {
   scoped_ptr<base::DictionaryValue> schema(
       LoadDictionary("choices_schema.json"));
 
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(base::Value::CreateNullValue()).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
               schema.get(), NULL);
 
   scoped_ptr<base::DictionaryValue> instance(new base::DictionaryValue());
   instance->SetString("foo", "bar");
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
   ExpectNotValid(TEST_SOURCE,
                  scoped_ptr<base::Value>(new base::StringValue("foo")).get(),
-                 schema.get(), NULL, "", JSONSchemaValidator::kInvalidChoice);
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::kInvalidChoice);
   ExpectNotValid(TEST_SOURCE,
                  scoped_ptr<base::Value>(new base::ListValue()).get(),
-                 schema.get(), NULL, "", JSONSchemaValidator::kInvalidChoice);
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::kInvalidChoice);
 
   instance->SetInteger("foo", 42);
-  ExpectNotValid(TEST_SOURCE, instance.get(),
-                 schema.get(), NULL, "", JSONSchemaValidator::kInvalidChoice);
+  ExpectNotValid(TEST_SOURCE,
+                 instance.get(),
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::kInvalidChoice);
 }
 
 void JSONSchemaValidatorTestBase::TestExtends() {
   // TODO(aa): JS only
 }
 
 void JSONSchemaValidatorTestBase::TestObject() {
   scoped_ptr<base::DictionaryValue> schema(new base::DictionaryValue());
   schema->SetString(schema::kType, schema::kObject);
   schema->SetString("properties.foo.type", schema::kString);
@@ skipping 132 matching lines @@
       LoadDictionary("array_tuple_schema.json"));
   ASSERT_TRUE(schema.get());
 
   scoped_ptr<base::ListValue> instance(new base::ListValue());
   instance->Append(new base::StringValue("42"));
   instance->Append(new base::FundamentalValue(42));
 
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
   instance->Append(new base::StringValue("anything"));
-  ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "",
+  ExpectNotValid(TEST_SOURCE,
+                 instance.get(),
+                 schema.get(),
+                 NULL,
+                 std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMaxItems, "2"));
 
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "1",
                  JSONSchemaValidator::kArrayItemRequired);
 
   instance->Set(0, new base::FundamentalValue(42));
   instance->Append(new base::FundamentalValue(42));
@@ skipping 49 matching lines @@
 
   scoped_ptr<base::ListValue> instance(new base::ListValue());
   instance->Append(new base::StringValue("x"));
   instance->Append(new base::StringValue("x"));
 
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
   instance->Append(new base::StringValue("x"));
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
   instance->Append(new base::StringValue("x"));
-  ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "",
+  ExpectNotValid(TEST_SOURCE,
+                 instance.get(),
+                 schema.get(),
+                 NULL,
+                 std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMaxItems, "3"));
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
-  ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "",
+  ExpectNotValid(TEST_SOURCE,
+                 instance.get(),
+                 schema.get(),
+                 NULL,
+                 std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMinItems, "2"));
 
   instance->Remove(1, NULL);
   instance->Append(new base::FundamentalValue(42));
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "1",
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kInvalidType,
                      schema::kString,
                      schema::kInteger));
 }
 
 void JSONSchemaValidatorTestBase::TestString() {
   scoped_ptr<base::DictionaryValue> schema(new base::DictionaryValue());
   schema->SetString(schema::kType, schema::kString);
   schema->SetInteger(schema::kMinLength, 1);
   schema->SetInteger(schema::kMaxLength, 10);
 
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::StringValue("x")).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(
                   new base::StringValue("xxxxxxxxxx")).get(),
               schema.get(), NULL);
 
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::StringValue("")).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kStringMinLength, "1"));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::StringValue(std::string())).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kStringMinLength, "1"));
   ExpectNotValid(
       TEST_SOURCE,
       scoped_ptr<base::Value>(new base::StringValue("xxxxxxxxxxx")).get(),
-      schema.get(), NULL, "",
+      schema.get(),
+      NULL,
+      std::string(),
       JSONSchemaValidator::FormatErrorMessage(
           JSONSchemaValidator::kStringMaxLength, "10"));
 }
 
 void JSONSchemaValidatorTestBase::TestNumber() {
   scoped_ptr<base::DictionaryValue> schema(new base::DictionaryValue());
   schema->SetString(schema::kType, schema::kNumber);
   schema->SetInteger(schema::kMinimum, 1);
   schema->SetInteger(schema::kMaximum, 100);
   schema->SetInteger("maxDecimal", 2);
 
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(1)).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(50)).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(100)).get(),
               schema.get(), NULL);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(new base::FundamentalValue(88.88)).get(),
               schema.get(), NULL);
 
-  ExpectNotValid(
-      TEST_SOURCE,
-      scoped_ptr<base::Value>(new base::FundamentalValue(0.5)).get(),
-      schema.get(), NULL, "",
-      JSONSchemaValidator::FormatErrorMessage(
-          JSONSchemaValidator::kNumberMinimum, "1"));
+  ExpectNotValid(TEST_SOURCE,
+                 scoped_ptr<base::Value>(new base::FundamentalValue(0.5)).get(),
+                 schema.get(),
+                 NULL,
+                 std::string(),
+                 JSONSchemaValidator::FormatErrorMessage(
+                     JSONSchemaValidator::kNumberMinimum, "1"));
   ExpectNotValid(
       TEST_SOURCE,
       scoped_ptr<base::Value>(new base::FundamentalValue(100.1)).get(),
-      schema.get(), NULL, "",
+      schema.get(),
+      NULL,
+      std::string(),
       JSONSchemaValidator::FormatErrorMessage(
           JSONSchemaValidator::kNumberMaximum, "100"));
 }
 
 void JSONSchemaValidatorTestBase::TestTypeClassifier() {
   EXPECT_EQ(std::string(schema::kBoolean),
             JSONSchemaValidator::GetJSONSchemaType(
                 scoped_ptr<base::Value>(
                     new base::FundamentalValue(true)).get()));
   EXPECT_EQ(std::string(schema::kBoolean),
@@ skipping 107 matching lines @@
               scoped_ptr<base::Value>(new base::FundamentalValue(true)).get(),
               schema.get(), NULL);
 
   schema->SetString(schema::kType, schema::kNull);
   ExpectValid(TEST_SOURCE,
               scoped_ptr<base::Value>(base::Value::CreateNullValue()).get(),
               schema.get(), NULL);
 
   // not valid
   schema->SetString(schema::kType, schema::kObject);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::ListValue()).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kObject,
-                     schema::kArray));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::ListValue()).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kInvalidType, schema::kObject, schema::kArray));
 
   schema->SetString(schema::kType, schema::kObject);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(base::Value::CreateNullValue()).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kObject,
-                     schema::kNull));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(base::Value::CreateNullValue()).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kInvalidType, schema::kObject, schema::kNull));
 
   schema->SetString(schema::kType, schema::kArray);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kArray,
-                     schema::kInteger));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kInvalidType, schema::kArray, schema::kInteger));
 
   schema->SetString(schema::kType, schema::kString);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kString,
-                     schema::kInteger));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::FundamentalValue(42)).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(JSONSchemaValidator::kInvalidType,
+                                              schema::kString,
+                                              schema::kInteger));
 
   schema->SetString(schema::kType, schema::kNumber);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::StringValue("42")).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kNumber,
-                     schema::kString));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::StringValue("42")).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kInvalidType, schema::kNumber, schema::kString));
 
   schema->SetString(schema::kType, schema::kInteger);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(
-                     new base::FundamentalValue(88.8)).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::kInvalidTypeIntegerNumber);
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::FundamentalValue(88.8)).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::kInvalidTypeIntegerNumber);
 
   schema->SetString(schema::kType, schema::kBoolean);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(new base::FundamentalValue(1)).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kBoolean,
-                     schema::kInteger));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::FundamentalValue(1)).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(JSONSchemaValidator::kInvalidType,
+                                              schema::kBoolean,
+                                              schema::kInteger));
 
   schema->SetString(schema::kType, schema::kNull);
-  ExpectNotValid(TEST_SOURCE,
-                 scoped_ptr<base::Value>(
-                     new base::FundamentalValue(false)).get(),
-                 schema.get(), NULL, "",
-                 JSONSchemaValidator::FormatErrorMessage(
-                     JSONSchemaValidator::kInvalidType,
-                     schema::kNull,
-                     schema::kBoolean));
+  ExpectNotValid(
+      TEST_SOURCE,
+      scoped_ptr<base::Value>(new base::FundamentalValue(false)).get(),
+      schema.get(),
+      NULL,
+      std::string(),
+      JSONSchemaValidator::FormatErrorMessage(
+          JSONSchemaValidator::kInvalidType, schema::kNull, schema::kBoolean));
 }