Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/common/extensions/features/complex_feature.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/features/complex_feature.h" 5 #include "chrome/common/extensions/features/complex_feature.h"
6 6
7 #include "chrome/common/extensions/features/simple_feature.h" 7 #include "chrome/common/extensions/features/simple_feature.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 bool ComplexFeature::IsInternal() const { 70 bool ComplexFeature::IsInternal() const {
71 NOTREACHED(); 71 NOTREACHED();
72 return false; 72 return false;
73 } 73 }
74 74
75 std::string ComplexFeature::GetAvailabilityMessage(AvailabilityResult result, 75 std::string ComplexFeature::GetAvailabilityMessage(AvailabilityResult result,
76 Manifest::Type type, 76 Manifest::Type type,
77 const GURL& url) const { 77 const GURL& url) const {
78 if (result == IS_AVAILABLE) 78 if (result == IS_AVAILABLE)
79 return ""; 79 return std::string();
80 80
81 // TODO(justinlin): Form some kind of combined availabilities/messages from 81 // TODO(justinlin): Form some kind of combined availabilities/messages from
82 // SimpleFeatures. 82 // SimpleFeatures.
83 return features_[0]->GetAvailabilityMessage(result, type, url); 83 return features_[0]->GetAvailabilityMessage(result, type, url);
84 } 84 }
85 85
86 } // namespace extensions 86 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/features/api_feature.cc ('k') | chrome/common/extensions/features/manifest_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698