Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/common/extensions/features/api_feature.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/features/api_feature.h" 5 #include "chrome/common/extensions/features/api_feature.h"
6 6
7 namespace extensions { 7 namespace extensions {
8 8
9 APIFeature::APIFeature() : internal_(false) { 9 APIFeature::APIFeature() : internal_(false) {
10 } 10 }
11 11
12 APIFeature::~APIFeature() { 12 APIFeature::~APIFeature() {
13 } 13 }
14 14
15 bool APIFeature::IsInternal() const { 15 bool APIFeature::IsInternal() const {
16 return internal_; 16 return internal_;
17 } 17 }
18 18
19 std::string APIFeature::Parse(const DictionaryValue* value) { 19 std::string APIFeature::Parse(const DictionaryValue* value) {
20 std::string error = SimpleFeature::Parse(value); 20 std::string error = SimpleFeature::Parse(value);
21 if (!error.empty()) 21 if (!error.empty())
22 return error; 22 return error;
23 23
24 value->GetBoolean("internal", &internal_); 24 value->GetBoolean("internal", &internal_);
25 25
26 if (GetContexts()->empty()) 26 if (GetContexts()->empty())
27 return name() + ": API features must specify at least one context."; 27 return name() + ": API features must specify at least one context.";
28 28
29 return ""; 29 return std::string();
30 } 30 }
31 31
32 } // namespace 32 } // namespace
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/common/extensions/features/complex_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698