Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/ui/webui/options/content_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 105 matching lines @@
     case CONTENT_SETTING_BLOCK:
       return "block";
     case CONTENT_SETTING_SESSION_ONLY:
       return "session";
     case CONTENT_SETTING_DEFAULT:
       return "default";
     case CONTENT_SETTING_NUM_SETTINGS:
       NOTREACHED();
   }
 
-  return "";
+  return std::string();
 }
 
 ContentSetting ContentSettingFromString(const std::string& name) {
   if (name == "allow")
     return CONTENT_SETTING_ALLOW;
   if (name == "ask")
     return CONTENT_SETTING_ASK;
   if (name == "block")
     return CONTENT_SETTING_BLOCK;
   if (name == "session")
     return CONTENT_SETTING_SESSION_ONLY;
 
   NOTREACHED() << name << " is not a recognized content setting.";
   return CONTENT_SETTING_DEFAULT;
 }
 
 // Create a DictionaryValue* that will act as a data source for a single row
 // in a HostContentSettingsMap-controlled exceptions table (e.g., cookies).
 // Ownership of the pointer is passed to the caller.
 DictionaryValue* GetExceptionForPage(
     const ContentSettingsPattern& pattern,
     const ContentSettingsPattern& secondary_pattern,
     const ContentSetting& setting,
     const std::string& provider_name) {
   DictionaryValue* exception = new DictionaryValue();
   exception->SetString(kOrigin, pattern.ToString());
   exception->SetString(kEmbeddingOrigin,
-      secondary_pattern == ContentSettingsPattern::Wildcard() ? "" :
-          secondary_pattern.ToString());
+                       secondary_pattern == ContentSettingsPattern::Wildcard()
+                           ? std::string()
+                           : secondary_pattern.ToString());
   exception->SetString(kSetting, ContentSettingToString(setting));
   exception->SetString(kSource, provider_name);
   return exception;
 }
 
 // Create a DictionaryValue* that will act as a data source for a single row
 // in the Geolocation exceptions table. Ownership of the pointer is passed to
 // the caller.
 DictionaryValue* GetGeolocationExceptionForPage(
     const ContentSettingsPattern& origin,
@@ skipping 431 matching lines @@
     filter_settings.SetString(group_name + ".value",
                               ContentSettingToString(CONTENT_SETTING_BLOCK));
     filter_settings.SetString(group_name + ".managedBy", "policy");
     web_ui()->CallJavascriptFunction(
         "ContentSettings.setContentFilterSettingsValue", filter_settings);
   }
 
   media_ui_settings.SetString("askText", "mediaStreamAsk");
   media_ui_settings.SetString("blockText", "mediaStreamBlock");
   media_ui_settings.SetBoolean("showBubble", false);
-  media_ui_settings.SetString("bubbleText", "");
+  media_ui_settings.SetString("bubbleText", std::string());
 
   web_ui()->CallJavascriptFunction("ContentSettings.updateMediaUI",
                                    media_ui_settings);
 }
 
 std::string ContentSettingsHandler::GetSettingDefaultFromModel(
     ContentSettingsType type, std::string* provider_id) {
   Profile* profile = Profile::FromWebUI(web_ui());
   ContentSetting default_setting;
   if (type == CONTENT_SETTINGS_TYPE_NOTIFICATIONS) {
@@ skipping 427 matching lines @@
   DCHECK(rv);
 
   std::string pattern;
   rv = args->GetString(arg_index++, &pattern);
   DCHECK(rv);
 
   HostContentSettingsMap* settings_map =
       mode == "normal" ? GetContentSettingsMap() :
                          GetOTRContentSettingsMap();
   if (settings_map) {
-    settings_map->SetWebsiteSetting(
-        ContentSettingsPattern::FromString(pattern),
-        ContentSettingsPattern::Wildcard(),
-        CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
-        "",
-        NULL);
-    settings_map->SetWebsiteSetting(
-        ContentSettingsPattern::FromString(pattern),
-        ContentSettingsPattern::Wildcard(),
-        CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
-        "",
-        NULL);
+    settings_map->SetWebsiteSetting(ContentSettingsPattern::FromString(pattern),
+                                    ContentSettingsPattern::Wildcard(),
+                                    CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
+                                    std::string(),
+                                    NULL);
+    settings_map->SetWebsiteSetting(ContentSettingsPattern::FromString(pattern),
+                                    ContentSettingsPattern::Wildcard(),
+                                    CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
+                                    std::string(),
+                                    NULL);
   }
 }
 
 void ContentSettingsHandler::RemoveExceptionFromHostContentSettingsMap(
     const ListValue* args, size_t arg_index,
     ContentSettingsType type) {
   std::string mode;
   bool rv = args->GetString(arg_index++, &mode);
   DCHECK(rv);
 
   std::string pattern;
   rv = args->GetString(arg_index++, &pattern);
   DCHECK(rv);
 
   std::string secondary_pattern;
   rv = args->GetString(arg_index++, &secondary_pattern);
   DCHECK(rv);
 
   HostContentSettingsMap* settings_map =
       mode == "normal" ? GetContentSettingsMap() :
                          GetOTRContentSettingsMap();
   if (settings_map) {
     settings_map->SetWebsiteSetting(
         ContentSettingsPattern::FromString(pattern),
-        secondary_pattern.empty() ? ContentSettingsPattern::Wildcard() :
-            ContentSettingsPattern::FromString(secondary_pattern),
+        secondary_pattern.empty()
+            ? ContentSettingsPattern::Wildcard()
+            : ContentSettingsPattern::FromString(secondary_pattern),
         type,
-        "",
+        std::string(),
         NULL);
   }
 }
 
 void ContentSettingsHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback("setContentFilter",
       base::Bind(&ContentSettingsHandler::SetContentFilter,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("removeException",
       base::Bind(&ContentSettingsHandler::RemoveException,
@@ skipping 147 matching lines @@
         mode == "normal" ? GetContentSettingsMap() :
                            GetOTRContentSettingsMap();
 
     // The settings map could be null if the mode was OTR but the OTR profile
     // got destroyed before we received this message.
     if (!settings_map)
       return;
     settings_map->SetContentSetting(ContentSettingsPattern::FromString(pattern),
                                     ContentSettingsPattern::Wildcard(),
                                     type,
-                                    "",
+                                    std::string(),
                                     ContentSettingFromString(setting));
   }
 }
 
 void ContentSettingsHandler::CheckExceptionPatternValidity(
     const ListValue* args) {
   size_t arg_i = 0;
   std::string type_string;
   CHECK(args->GetString(arg_i++, &type_string));
   std::string mode_string;
@@ skipping 113 matching lines @@
             media_settings_.flash_default_setting,
             media_settings_.flash_exceptions,
             media_settings_.policy_disable_audio,
             media_settings_.policy_disable_video)) {
       ShowFlashMediaLink(EXCEPTIONS, true);
     }
   }
 }
 
 }  // namespace options