chrome/browser/ui/webui/inspect_ui.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/feedback_ui.cc ('k') | chrome/browser/ui/webui/instant_ui.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/inspect_ui.h"	5 #include "chrome/browser/ui/webui/inspect_ui.h"

6	6

7 #include <set>	7 #include <set>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/bind_helpers.h"	10 #include "base/bind_helpers.h"

(...skipping 444 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
455 DictionaryValue* target_data = BuildTargetDescriptor(kAdbTargetType,	455 DictionaryValue* target_data = BuildTargetDescriptor(kAdbTargetType,

456 false, GURL(page->url()), page->title(), GURL(page->favicon_url()), 0,	456 false, GURL(page->url()), page->title(), GURL(page->favicon_url()), 0,

457 0);	457 0);

458 target_data->SetString(kAdbSerialField, page->serial());	458 target_data->SetString(kAdbSerialField, page->serial());

459 target_data->SetString(kAdbModelField, page->model());	459 target_data->SetString(kAdbModelField, page->model());

460 target_data->SetString(kAdbDebugUrlField, page->debug_url());	460 target_data->SetString(kAdbDebugUrlField, page->debug_url());

461 target_data->SetString(kAdbFrontendUrlField, page->frontend_url());	461 target_data->SetString(kAdbFrontendUrlField, page->frontend_url());

462 targets.Append(target_data);	462 targets.Append(target_data);

463 }	463 }

464	464

465 std::string json_string = "";	465 std::string json_string;

466 base::JSONWriter::Write(&targets, &json_string);	466 base::JSONWriter::Write(&targets, &json_string);

467 callback.Run(base::RefCountedString::TakeString(&json_string));	467 callback.Run(base::RefCountedString::TakeString(&json_string));

468 }	468 }

OLD	NEW