Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: chrome/browser/translate/translate_manager_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_manager.h" 5 #include "chrome/browser/translate/translate_manager.h"
6 6
7 #include "content/public/common/url_constants.h" 7 #include "content/public/common/url_constants.h"
8 #include "googleurl/src/gurl.h" 8 #include "googleurl/src/gurl.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 #ifdef FILE_MANAGER_EXTENSION 11 #ifdef FILE_MANAGER_EXTENSION
12 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h" 12 #include "chrome/browser/chromeos/extensions/file_manager/file_manager_util.h"
13 #include "extensions/common/constants.h" 13 #include "extensions/common/constants.h"
14 #endif 14 #endif
15 15
16 typedef testing::Test TranslateManagerTest; 16 typedef testing::Test TranslateManagerTest;
17 17
18 TEST_F(TranslateManagerTest, CheckTranslatableURL) { 18 TEST_F(TranslateManagerTest, CheckTranslatableURL) {
19 GURL empty_url = GURL(""); 19 GURL empty_url = GURL(std::string());
20 EXPECT_FALSE(TranslateManager::IsTranslatableURL(empty_url)); 20 EXPECT_FALSE(TranslateManager::IsTranslatableURL(empty_url));
21 21
22 std::string chrome = std::string(chrome::kChromeUIScheme) + "://flags"; 22 std::string chrome = std::string(chrome::kChromeUIScheme) + "://flags";
23 GURL chrome_url = GURL(chrome); 23 GURL chrome_url = GURL(chrome);
24 EXPECT_FALSE(TranslateManager::IsTranslatableURL(chrome_url)); 24 EXPECT_FALSE(TranslateManager::IsTranslatableURL(chrome_url));
25 25
26 std::string devtools = std::string(chrome::kChromeDevToolsScheme) + "://"; 26 std::string devtools = std::string(chrome::kChromeDevToolsScheme) + "://";
27 GURL devtools_url = GURL(devtools); 27 GURL devtools_url = GURL(devtools);
28 EXPECT_FALSE(TranslateManager::IsTranslatableURL(devtools_url)); 28 EXPECT_FALSE(TranslateManager::IsTranslatableURL(devtools_url));
29 29
30 #ifdef FILE_MANAGER_EXTENSION 30 #ifdef FILE_MANAGER_EXTENSION
31 std::string filemanager = 31 std::string filemanager =
32 std::string(extensions::kExtensionScheme) + 32 std::string(extensions::kExtensionScheme) +
33 std::string("://") + 33 std::string("://") +
34 std::string(kFileBrowserDomain); 34 std::string(kFileBrowserDomain);
35 GURL filemanager_url = GURL(filemanager); 35 GURL filemanager_url = GURL(filemanager);
36 EXPECT_FALSE(TranslateManager::IsTranslatableURL(filemanager_url)); 36 EXPECT_FALSE(TranslateManager::IsTranslatableURL(filemanager_url));
37 #endif 37 #endif
38 38
39 std::string ftp = std::string(chrome::kFtpScheme) + "://google.com/pub"; 39 std::string ftp = std::string(chrome::kFtpScheme) + "://google.com/pub";
40 GURL ftp_url = GURL(ftp); 40 GURL ftp_url = GURL(ftp);
41 EXPECT_FALSE(TranslateManager::IsTranslatableURL(ftp_url)); 41 EXPECT_FALSE(TranslateManager::IsTranslatableURL(ftp_url));
42 42
43 GURL right_url = GURL("http://www.tamurayukari.com/"); 43 GURL right_url = GURL("http://www.tamurayukari.com/");
44 EXPECT_TRUE(TranslateManager::IsTranslatableURL(right_url)); 44 EXPECT_TRUE(TranslateManager::IsTranslatableURL(right_url));
45 } 45 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/browser/ui/app_list/app_list_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698