Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/signin/signin_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_manager.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
@@ skipping 290 matching lines @@
   scoped_ptr<content::TestBrowserThread> io_thread_;
   std::vector<std::string> cookies_;
 };
 
 // NOTE: ClientLogin's "StartSignin" is called after collecting credentials
 //       from the user.
 TEST_F(SigninManagerTest, SignInClientLogin) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
-  manager_->StartSignIn("user@gmail.com", "password", "", "");
+  manager_->StartSignIn(
+      "user@gmail.com", "password", std::string(), std::string());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   SimulateValidResponseClientLogin(true);
   EXPECT_FALSE(manager_->GetAuthenticatedUsername().empty());
 
   // Should go into token service and stop.
   EXPECT_EQ(1U, google_login_success_.size());
   EXPECT_EQ(0U, google_login_failure_.size());
 
   service_->OnIssueAuthTokenSuccess(GaiaConstants::kGaiaOAuth2LoginRefreshToken,
@@ skipping 11 matching lines @@
 }
 
 TEST_F(SigninManagerTest, Prohibited) {
   g_browser_process->local_state()->SetString(
       prefs::kGoogleServicesUsernamePattern, ".*@google.com");
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->IsAllowedUsername("test@google.com"));
   EXPECT_TRUE(manager_->IsAllowedUsername("happy@google.com"));
   EXPECT_FALSE(manager_->IsAllowedUsername("test@invalid.com"));
   EXPECT_FALSE(manager_->IsAllowedUsername("test@notgoogle.com"));
-  EXPECT_FALSE(manager_->IsAllowedUsername(""));
+  EXPECT_FALSE(manager_->IsAllowedUsername(std::string()));
 }
 
 TEST_F(SigninManagerTest, TestAlternateWildcard) {
   // Test to make sure we accept "*@google.com" as a pattern (treat it as if
   // the admin entered ".*@google.com").
   g_browser_process->local_state()->SetString(
       prefs::kGoogleServicesUsernamePattern, "*@google.com");
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->IsAllowedUsername("test@google.com"));
   EXPECT_TRUE(manager_->IsAllowedUsername("happy@google.com"));
   EXPECT_FALSE(manager_->IsAllowedUsername("test@invalid.com"));
   EXPECT_FALSE(manager_->IsAllowedUsername("test@notgoogle.com"));
-  EXPECT_FALSE(manager_->IsAllowedUsername(""));
+  EXPECT_FALSE(manager_->IsAllowedUsername(std::string()));
 }
 
 TEST_F(SigninManagerTest, ProhibitedAtStartup) {
   profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername,
                                   "monkey@invalid.com");
   g_browser_process->local_state()->SetString(
       prefs::kGoogleServicesUsernamePattern, ".*@google.com");
   manager_->Initialize(profile_.get());
   // Currently signed in user is prohibited by policy, so should be signed out.
   EXPECT_EQ("", manager_->GetAuthenticatedUsername());
@@ skipping 47 matching lines @@
   scoped_refptr<net::CookieMonster> cookie_monster =
       profile_->GetCookieMonster();
   net::CookieOptions options;
   options.set_include_httponly();
   cookie_monster->SetCookieWithOptionsAsync(
         GURL("https://accounts.google.com"),
         "LSID=1234; secure; httponly", options,
         net::CookieMonster::SetCookiesCallback());
 
   // Since the password is empty, will verify the gaia cookies first.
-  manager_->StartSignInWithCredentials("0", "user@gmail.com", "");
+  manager_->StartSignInWithCredentials("0", "user@gmail.com", std::string());
 
   WaitUntilUIDone();
 
   // Verification should succeed and continue with auto signin.
   ExpectSignInWithCredentialsSuccess();
 }
 
 TEST_F(SigninManagerTest, SignInWithCredentialsEmptyPasswordNoValidCookie) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   // Since the password is empty, will verify the gaia cookies first.
-  manager_->StartSignInWithCredentials("0", "user@gmail.com", "");
+  manager_->StartSignInWithCredentials("0", "user@gmail.com", std::string());
 
   WaitUntilUIDone();
 
   // Since the test cookie store is empty, verification should fail and throws
   // a login error.
   ExpectSignInWithCredentialsFail(false /* requestSent */);
 }
 
 TEST_F(SigninManagerTest, SignInWithCredentialsEmptyPasswordInValidCookie) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   // Set an invalid LSID cookie in the test cookie store.
   scoped_refptr<net::CookieMonster> cookie_monster =
       profile_->GetCookieMonster();
   net::CookieOptions options;
   options.set_include_httponly();
   cookie_monster->SetCookieWithOptionsAsync(
         GURL("https://accounts.google.com"),
         "LSID=1234; domain=google.com; secure; httponly", options,
         net::CookieMonster::SetCookiesCallback());
 
   // Since the password is empty, must verify the gaia cookies first.
-  manager_->StartSignInWithCredentials("0", "user@gmail.com", "");
+  manager_->StartSignInWithCredentials("0", "user@gmail.com", std::string());
 
   WaitUntilUIDone();
 
   // Since the LSID cookie is invalid, verification should fail and throws
   // a login error.
   ExpectSignInWithCredentialsFail(false /* requestSent */);
 }
 
 TEST_F(SigninManagerTest, SignInClientLoginNoGPlus) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   SimulateValidResponseClientLogin(false);
   EXPECT_FALSE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, ClearTransientSigninData) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   SimulateValidResponseClientLogin(false);
 
   // Should go into token service and stop.
   EXPECT_EQ(1U, google_login_success_.size());
   EXPECT_EQ(0U, google_login_failure_.size());
 
   EXPECT_EQ("user@gmail.com", manager_->GetAuthenticatedUsername());
 
@@ skipping 10 matching lines @@
   manager_->Shutdown();
   manager_.reset(new SigninManager());
   manager_->Initialize(profile_.get());
 
   // Now make sure we have the right user name.
   EXPECT_EQ("user@gmail.com", manager_->GetAuthenticatedUsername());
 }
 
 TEST_F(SigninManagerTest, SignOutClientLogin) {
   manager_->Initialize(profile_.get());
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   SimulateValidResponseClientLogin(false);
   manager_->OnClientLoginSuccess(credentials_);
 
   EXPECT_EQ("user@gmail.com", manager_->GetAuthenticatedUsername());
   manager_->SignOut();
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
   // Should not be persisted anymore
   manager_->Shutdown();
   manager_.reset(new SigninManager());
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, SignInFailureClientLogin) {
   manager_->Initialize(profile_.get());
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   GoogleServiceAuthError error(GoogleServiceAuthError::REQUEST_CANCELED);
   manager_->OnClientLoginFailure(error);
 
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(1U, google_login_failure_.size());
 
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   // Should not be persisted
   manager_->Shutdown();
   manager_.reset(new SigninManager());
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, ProvideSecondFactorSuccess) {
   manager_->Initialize(profile_.get());
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   GoogleServiceAuthError error(GoogleServiceAuthError::TWO_FACTOR);
   manager_->OnClientLoginFailure(error);
 
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(1U, google_login_failure_.size());
 
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
   EXPECT_FALSE(manager_->possibly_invalid_username_.empty());
 
   manager_->ProvideSecondFactorAccessCode("access");
   SimulateValidResponseClientLogin(false);
 
   EXPECT_EQ(1U, google_login_success_.size());
   EXPECT_EQ(1U, google_login_failure_.size());
 }
 
 TEST_F(SigninManagerTest, ProvideSecondFactorFailure) {
   manager_->Initialize(profile_.get());
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   GoogleServiceAuthError error1(GoogleServiceAuthError::TWO_FACTOR);
   manager_->OnClientLoginFailure(error1);
 
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(1U, google_login_failure_.size());
 
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
   EXPECT_FALSE(manager_->possibly_invalid_username_.empty());
 
   manager_->ProvideSecondFactorAccessCode("badaccess");
   GoogleServiceAuthError error2(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   manager_->OnClientLoginFailure(error2);
 
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(2U, google_login_failure_.size());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   manager_->ProvideSecondFactorAccessCode("badaccess");
   GoogleServiceAuthError error3(GoogleServiceAuthError::CONNECTION_FAILED);
   manager_->OnClientLoginFailure(error3);
 
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(3U, google_login_failure_.size());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, SignOutMidConnect) {
   manager_->Initialize(profile_.get());
-  manager_->StartSignIn("username", "password", "", "");
+  manager_->StartSignIn("username", "password", std::string(), std::string());
   manager_->SignOut();
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(0U, google_login_failure_.size());
 
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, SignInWithOAuth) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
@@ skipping 66 matching lines @@
       GURL("http://accounts.google.com/ServiceLogin?service=chromiumsync")));
   // http, not https, should not be treated as web based signin.
   EXPECT_FALSE(SigninManager::IsWebBasedSigninFlowURL(
       GURL("http://accounts.google.com/ServiceLogin?service=googlemail")));
   // chromiumsync is double-embedded in a continue query param.
   EXPECT_TRUE(SigninManager::IsWebBasedSigninFlowURL(
       GURL("https://accounts.google.com/CheckCookie?"
            "continue=https%3A%2F%2Fwww.google.com%2Fintl%2Fen-US%2Fchrome"
            "%2Fblank.html%3Fsource%3D3%26nonadv%3D1&service=chromiumsync")));
 }