Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/safe_browsing/protocol_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 
 #include "base/stringprintf.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/time.h"
 #include "chrome/browser/safe_browsing/protocol_manager.h"
@@ skipping 360 matching lines @@
   EXPECT_EQ("goog-phish-shavar;a:adds_phish:s:subs_phish\n"
             "unknown_list;a:adds_unknown:s:subs_unknown\n"
             "goog-malware-shavar;\n",
             url_fetcher->upload_data());
   EXPECT_EQ(GURL("https://prefix.com/foo/downloads?client=unittest&appver=1.0"
                  "&pver=2.2" + key_param_),
             url_fetcher->GetOriginalURL());
 
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(200);
-  url_fetcher->SetResponseString("");
+  url_fetcher->SetResponseString(std::string());
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseBadBodyBackupSuccess) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
   base::ThreadTaskRunnerHandle runner_handler(runner);
   net::TestURLFetcherFactory url_fetcher_factory;
@@ skipping 25 matching lines @@
 
   // There should now be a backup request.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupHttpUrlPrefix);
 
   // Respond to the backup successfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(200);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is an HTTP error response to the update
 // request, as well as an error response to the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseHttpErrorBackupError) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
@@ skipping 15 matching lines @@
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // We should have an URLFetcher at this point in time.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
 
   // Go ahead and respond to it.
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(404);
-  url_fetcher->SetResponseString("");
+  url_fetcher->SetResponseString(std::string());
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // There should now be a backup request.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher, kBackupHttpUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(404);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is an HTTP error response to the update
 // request, followed by a successful response to the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseHttpErrorBackupSuccess) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
@@ skipping 15 matching lines @@
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // We should have an URLFetcher at this point in time.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
 
   // Go ahead and respond to it.
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(404);
-  url_fetcher->SetResponseString("");
+  url_fetcher->SetResponseString(std::string());
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // There should now be a backup request.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupHttpUrlPrefix);
 
   // Respond to the backup successfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(200);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is an HTTP error response to the update
 // request, and a timeout on the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseHttpErrorBackupTimeout) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
@@ skipping 15 matching lines @@
   pm->ForceScheduleNextUpdate(TimeDelta());
   runner->RunPendingTasks();
 
   // We should have an URLFetcher at this point in time.
   net::TestURLFetcher* url_fetcher = url_fetcher_factory.GetFetcherByID(0);
   ValidateUpdateFetcherRequest(url_fetcher);
 
   // Go ahead and respond to it.
   url_fetcher->set_status(net::URLRequestStatus());
   url_fetcher->set_response_code(404);
-  url_fetcher->SetResponseString("");
+  url_fetcher->SetResponseString(std::string());
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // There should now be a backup request.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher, kBackupHttpUrlPrefix);
 
   // Either one or two calls to RunPendingTasks are needed here. The first run
   // of RunPendingTasks will run the canceled timeout task associated with
   // the first Update request. Depending on timing, this will either directly
@@ skipping 41 matching lines @@
 
   // There should be a backup URLFetcher now.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupConnectUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(404);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is a connection error when issuing the update
 // request, and a successful response to the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest,
        UpdateResponseConnectionErrorBackupSuccess) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
@@ skipping 27 matching lines @@
 
   // There should be a backup URLFetcher now.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupConnectUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(200);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 // Tests what happens when there is a network state error when issuing the
 // update request, and an error with the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest,
        UpdateResponseNetworkErrorBackupError) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
@@ skipping 27 matching lines @@
 
   // There should be a backup URLFetcher now.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupNetworkUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(404);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is a network state error when issuing the
 // update request, and a successful response to the backup update request.
 TEST_F(SafeBrowsingProtocolManagerTest,
        UpdateResponseNetworkErrorBackupSuccess) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
@@ skipping 28 matching lines @@
 
   // There should be a backup URLFetcher now.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupNetworkUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(200);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is a timeout before an update response.
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseTimeoutBackupSuccess) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
   base::ThreadTaskRunnerHandle runner_handler(runner);
@@ skipping 24 matching lines @@
 
   // There should be a backup URLFetcher now.
   net::TestURLFetcher* backup_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateUpdateFetcherRequest(backup_url_fetcher,
                                kBackupConnectUrlPrefix);
 
   // Respond to the backup unsuccessfully.
   backup_url_fetcher->set_status(net::URLRequestStatus());
   backup_url_fetcher->set_response_code(200);
-  backup_url_fetcher->SetResponseString("");
+  backup_url_fetcher->SetResponseString(std::string());
   backup_url_fetcher->delegate()->OnURLFetchComplete(backup_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests what happens when there is a reset command in the response.
 TEST_F(SafeBrowsingProtocolManagerTest, UpdateResponseReset) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
   base::ThreadTaskRunnerHandle runner_handler(runner);
@@ skipping 60 matching lines @@
       "u:redirect-server.example.com/path\n");
   url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
 
   // The redirect response contains an empty body.
   net::TestURLFetcher* chunk_url_fetcher =
       url_fetcher_factory.GetFetcherByID(1);
   ValidateRedirectFetcherRequest(
       chunk_url_fetcher, "https://redirect-server.example.com/path");
   chunk_url_fetcher->set_status(net::URLRequestStatus());
   chunk_url_fetcher->set_response_code(200);
-  chunk_url_fetcher->SetResponseString("");
+  chunk_url_fetcher->SetResponseString(std::string());
   chunk_url_fetcher->delegate()->OnURLFetchComplete(chunk_url_fetcher);
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 // Tests a single valid update response, followed by a single redirect response
 // that has an invalid body.
 TEST_F(SafeBrowsingProtocolManagerTest, InvalidRedirectResponse) {
   scoped_refptr<base::TestSimpleTaskRunner> runner(
       new base::TestSimpleTaskRunner());
@@ skipping 160 matching lines @@
   second_chunk_url_fetcher->delegate()->OnURLFetchComplete(
       second_chunk_url_fetcher);
 
   EXPECT_FALSE(pm->IsUpdateScheduled());
 
   // Invoke the AddChunksCallback to finish the update.
   runner->RunPendingTasks();
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }