Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/plugins/plugin_metadata_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugins/plugin_metadata.h" 5 #include "chrome/browser/plugins/plugin_metadata.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "webkit/plugins/webplugininfo.h" 9 #include "webkit/plugins/webplugininfo.h"
10 10
(...skipping 16 matching lines...) Expand all
27 TEST(PluginMetadataTest, SecurityStatus) { 27 TEST(PluginMetadataTest, SecurityStatus) {
28 const PluginMetadata::SecurityStatus kUpToDate = 28 const PluginMetadata::SecurityStatus kUpToDate =
29 PluginMetadata::SECURITY_STATUS_UP_TO_DATE; 29 PluginMetadata::SECURITY_STATUS_UP_TO_DATE;
30 const PluginMetadata::SecurityStatus kOutOfDate = 30 const PluginMetadata::SecurityStatus kOutOfDate =
31 PluginMetadata::SECURITY_STATUS_OUT_OF_DATE; 31 PluginMetadata::SECURITY_STATUS_OUT_OF_DATE;
32 const PluginMetadata::SecurityStatus kRequiresAuthorization = 32 const PluginMetadata::SecurityStatus kRequiresAuthorization =
33 PluginMetadata::SECURITY_STATUS_REQUIRES_AUTHORIZATION; 33 PluginMetadata::SECURITY_STATUS_REQUIRES_AUTHORIZATION;
34 34
35 PluginMetadata plugin_metadata("claybrick-writer", 35 PluginMetadata plugin_metadata("claybrick-writer",
36 ASCIIToUTF16("ClayBrick Writer"), 36 ASCIIToUTF16("ClayBrick Writer"),
37 true, GURL(), GURL(), 37 true,
38 GURL(),
39 GURL(),
38 ASCIIToUTF16("ClayBrick"), 40 ASCIIToUTF16("ClayBrick"),
39 ""); 41 std::string());
40 #if defined(OS_LINUX) 42 #if defined(OS_LINUX)
41 EXPECT_EQ(kRequiresAuthorization, 43 EXPECT_EQ(kRequiresAuthorization,
42 GetSecurityStatus(&plugin_metadata, "1.2.3")); 44 GetSecurityStatus(&plugin_metadata, "1.2.3"));
43 #else 45 #else
44 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "1.2.3")); 46 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "1.2.3"));
45 #endif 47 #endif
46 48
47 plugin_metadata.AddVersion(Version("9.4.1"), kRequiresAuthorization); 49 plugin_metadata.AddVersion(Version("9.4.1"), kRequiresAuthorization);
48 plugin_metadata.AddVersion(Version("10"), kOutOfDate); 50 plugin_metadata.AddVersion(Version("10"), kOutOfDate);
49 plugin_metadata.AddVersion(Version("10.2.1"), kUpToDate); 51 plugin_metadata.AddVersion(Version("10.2.1"), kUpToDate);
50 52
51 // Invalid version. 53 // Invalid version.
52 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "foo")); 54 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "foo"));
53 55
54 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "0")); 56 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "0"));
55 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "1.2.3")); 57 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "1.2.3"));
56 EXPECT_EQ(kRequiresAuthorization, 58 EXPECT_EQ(kRequiresAuthorization,
57 GetSecurityStatus(&plugin_metadata, "9.4.1")); 59 GetSecurityStatus(&plugin_metadata, "9.4.1"));
58 EXPECT_EQ(kRequiresAuthorization, 60 EXPECT_EQ(kRequiresAuthorization,
59 GetSecurityStatus(&plugin_metadata, "9.4.2")); 61 GetSecurityStatus(&plugin_metadata, "9.4.2"));
60 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "10.2.0")); 62 EXPECT_EQ(kOutOfDate, GetSecurityStatus(&plugin_metadata, "10.2.0"));
61 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "10.2.1")); 63 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "10.2.1"));
62 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "11")); 64 EXPECT_EQ(kUpToDate, GetSecurityStatus(&plugin_metadata, "11"));
63 } 65 }
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_finder.cc ('k') | chrome/browser/policy/cloud/cloud_policy_refresh_scheduler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698