Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/google_apis/fake_drive_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google_apis/fake_drive_service.h"
 
 #include <string>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 78 matching lines @@
 };
 
 TEST_F(FakeDriveServiceTest, GetResourceList_All) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Do some sanity check.
   EXPECT_EQ(14U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_WithStartIndex) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL("http://dummyurl/?start-offset=2"),
-      0,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Because the start-offset was set to 2, the size should be 12 instead of
   // 14 (the total number).
   EXPECT_EQ(12U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_WithStartIndexAndMaxResults) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL("http://localhost/?start-offset=2&max-results=5"),
-      0,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Because the max-results was set to 5, the size should be 5 instead of 10.
   EXPECT_EQ(5U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
   // The next link should be provided. The new start-offset should be
   // 2 (original start index) + 5 (max results).
   const google_apis::Link* next_link =
       resource_list->GetLinkByType(Link::LINK_NEXT);
   ASSERT_TRUE(next_link);
   EXPECT_EQ(GURL("http://localhost/?start-offset=7&max-results=5"),
             next_link->href());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_WithDefaultMaxResultsChanged) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
   fake_service_.set_default_max_results(3);
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Because the default max results was changed to 3, the size should be 3
   // instead of 12 (the total number).
   EXPECT_EQ(3U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
   // The next link should be provided.
   const google_apis::Link* next_link =
       resource_list->GetLinkByType(Link::LINK_NEXT);
   ASSERT_TRUE(next_link);
   EXPECT_EQ(GURL("http://localhost/?start-offset=3&max-results=3"),
             next_link->href());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_InRootDirectory) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
-      "",  // search_query
+      0,                                  // start_changestamp
+      std::string(),                      // search_query
       fake_service_.GetRootResourceId(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Do some sanity check. There are 7 entries in the root directory.
   EXPECT_EQ(8U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_Search) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
-      "File",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      "File",         // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Do some sanity check. There are 4 entries that contain "File" in their
   // titles.
   EXPECT_EQ(4U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_SearchWithAttribute) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
+      0,              // start_changestamp
       "title:1.txt",  // search_query
-      "",  // directory_resource_id
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // Do some sanity check. There are 4 entries that contain "1.txt" in their
   // titles.
   EXPECT_EQ(4U, resource_list->entries().size());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_SearchMultipleQueries) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
+      0,              // start_changestamp
       "Directory 1",  // search_query
-      "",  // directory_resource_id
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // There are 2 entries that contain both "Directory" and "1" in their titles.
   EXPECT_EQ(2U, resource_list->entries().size());
 
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
+      0,                  // start_changestamp
       "\"Directory 1\"",  // search_query
-      "",  // directory_resource_id
+      std::string(),      // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // There is 1 entry that contain "Directory 1" in its title.
   EXPECT_EQ(1U, resource_list->entries().size());
   EXPECT_EQ(2, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_NoNewEntries) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
   // Load the account_metadata.json as well to add the largest changestamp
   // (654321) to the existing entries.
   ASSERT_TRUE(fake_service_.LoadAccountMetadataForWapi(
       "chromeos/gdata/account_metadata.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      654321 + 1,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      654321 + 1,     // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // This should be empty as the latest changestamp was passed to
   // GetResourceList(), hence there should be no new entries.
   EXPECT_EQ(0U, resource_list->entries().size());
   // It's considered loaded even if the result is empty.
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_WithNewEntry) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
   // Load the account_metadata.json as well to add the largest changestamp
   // (654321) to the existing entries.
   ASSERT_TRUE(fake_service_.LoadAccountMetadataForWapi(
       "chromeos/gdata/account_metadata.json"));
   // Add a new directory in the root directory. The new directory will have
   // the changestamp of 654322.
   ASSERT_TRUE(AddNewDirectory(
       fake_service_.GetRootResourceId(), "new directory"));
 
   // Get the resource list newer than 654321.
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      654321 + 1,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      654321 + 1,     // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   ASSERT_TRUE(resource_list);
   // The result should only contain the newly created directory.
   ASSERT_EQ(1U, resource_list->entries().size());
   EXPECT_EQ("new directory", resource_list->entries()[0]->title());
   EXPECT_EQ(1, fake_service_.resource_list_load_count());
 }
 
 TEST_F(FakeDriveServiceTest, GetResourceList_Offline) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
   fake_service_.set_offline(true);
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   scoped_ptr<ResourceList> resource_list;
   fake_service_.GetResourceList(
       GURL(),
-      0,  // start_changestamp
-      "",  // search_query
-      "",  // directory_resource_id
+      0,              // start_changestamp
+      std::string(),  // search_query
+      std::string(),  // directory_resource_id
       test_util::CreateCopyResultCallback(&error, &resource_list));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(GDATA_NO_CONNECTION, error);
   EXPECT_FALSE(resource_list);
 }
 
 TEST_F(FakeDriveServiceTest, GetAllResourceList) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
@@ skipping 468 matching lines @@
 
 TEST_F(FakeDriveServiceTest, DeleteResource_ExistingFile) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   // Resource "file:2_file_resource_id" should now exist.
   ASSERT_TRUE(Exists("file:2_file_resource_id"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   fake_service_.DeleteResource("file:2_file_resource_id",
-                               "",  // etag
+                               std::string(),  // etag
                                test_util::CreateCopyResultCallback(&error));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_SUCCESS, error);
   // Resource "file:2_file_resource_id" should be gone now.
   EXPECT_FALSE(Exists("file:2_file_resource_id"));
 }
 
 TEST_F(FakeDriveServiceTest, DeleteResource_NonexistingFile) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   fake_service_.DeleteResource("file:nonexisting_resource_id",
-                               "",  // etag
+                               std::string(),  // etag
                                test_util::CreateCopyResultCallback(&error));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_NOT_FOUND, error);
 }
 
 TEST_F(FakeDriveServiceTest, DeleteResource_Offline) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
   fake_service_.set_offline(true);
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   fake_service_.DeleteResource("file:2_file_resource_id",
-                               "",  // etag
+                               std::string(),  // etag
                                test_util::CreateCopyResultCallback(&error));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(GDATA_NO_CONNECTION, error);
 }
 
 TEST_F(FakeDriveServiceTest, DownloadFile_ExistingFile) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
@@ skipping 611 matching lines @@
       "chromeos/gdata/root_feed.json"));
   fake_service_.set_offline(true);
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   GURL upload_location;
   fake_service_.InitiateUploadExistingFile(
       base::FilePath(FILE_PATH_LITERAL("drive/File 1")),
       "test/foo",
       13,
       "file:2_file_resource_id",
-      "",  // etag
+      std::string(),  // etag
       test_util::CreateCopyResultCallback(&error, &upload_location));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(GDATA_NO_CONNECTION, error);
   EXPECT_TRUE(upload_location.is_empty());
 }
 
 TEST_F(FakeDriveServiceTest, InitiateUploadExistingFile_NotFound) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
 
   GDataErrorCode error = GDATA_OTHER_ERROR;
   GURL upload_location;
   fake_service_.InitiateUploadExistingFile(
       base::FilePath(FILE_PATH_LITERAL("drive/File 1")),
       "test/foo",
       13,
       "non_existent",
-      "",  // etag
+      std::string(),  // etag
       test_util::CreateCopyResultCallback(&error, &upload_location));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(HTTP_NOT_FOUND, error);
   EXPECT_TRUE(upload_location.is_empty());
 }
 
 TEST_F(FakeDriveServiceTest, InitiateUploadExistingFile_WrongETag) {
   ASSERT_TRUE(fake_service_.LoadResourceListForWapi(
       "chromeos/gdata/root_feed.json"));
@@ skipping 409 matching lines @@
       test_util::CreateCopyResultCallback(&error, &resource_entry));
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(GDATA_NO_CONNECTION, error);
   EXPECT_FALSE(resource_entry);
 }
 
 }  // namespace
 
 }  // namespace google_apis