Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: chrome/browser/extensions/tab_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/tab_helper.h" 5 #include "chrome/browser/extensions/tab_helper.h"
6 6
7 #include "chrome/browser/extensions/activity_log.h" 7 #include "chrome/browser/extensions/activity_log.h"
8 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h" 8 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
9 #include "chrome/browser/extensions/api/declarative_content/content_rules_regist ry.h" 9 #include "chrome/browser/extensions/api/declarative_content/content_rules_regist ry.h"
10 #include "chrome/browser/extensions/crx_installer.h" 10 #include "chrome/browser/extensions/crx_installer.h"
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 WindowController* TabHelper::GetExtensionWindowController() const { 406 WindowController* TabHelper::GetExtensionWindowController() const {
407 return ExtensionTabUtil::GetWindowControllerOfTab(web_contents()); 407 return ExtensionTabUtil::GetWindowControllerOfTab(web_contents());
408 } 408 }
409 409
410 void TabHelper::OnInlineInstallComplete(int install_id, 410 void TabHelper::OnInlineInstallComplete(int install_id,
411 int return_route_id, 411 int return_route_id,
412 bool success, 412 bool success,
413 const std::string& error) { 413 const std::string& error) {
414 if (success) { 414 if (success) {
415 Send(new ExtensionMsg_InlineWebstoreInstallResponse( 415 Send(new ExtensionMsg_InlineWebstoreInstallResponse(
416 return_route_id, install_id, true, "")); 416 return_route_id, install_id, true, std::string()));
417 } else { 417 } else {
418 Send(new ExtensionMsg_InlineWebstoreInstallResponse( 418 Send(new ExtensionMsg_InlineWebstoreInstallResponse(
419 return_route_id, install_id, false, error)); 419 return_route_id, install_id, false, error));
420 } 420 }
421 } 421 }
422 422
423 WebContents* TabHelper::GetAssociatedWebContents() const { 423 WebContents* TabHelper::GetAssociatedWebContents() const {
424 return web_contents(); 424 return web_contents();
425 } 425 }
426 426
(...skipping 29 matching lines...) Expand all
456 script_bubble_controller_->OnExtensionUnloaded( 456 script_bubble_controller_->OnExtensionUnloaded(
457 content::Details<extensions::UnloadedExtensionInfo>( 457 content::Details<extensions::UnloadedExtensionInfo>(
458 details)->extension->id()); 458 details)->extension->id());
459 break; 459 break;
460 } 460 }
461 } 461 }
462 } 462 }
463 } 463 }
464 464
465 } // namespace extensions 465 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698