Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/extensions/api/extension_action/page_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/browser_event_router.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_icon_factory.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 45 matching lines @@
   EXPECT_EQ("Modified", action->GetTitle(tab_id));
 
   {
     // Simulate the page action being clicked.
     ResultCatcher catcher;
     int tab_id = ExtensionTabUtil::GetTabId(
         browser()->tab_strip_model()->GetActiveWebContents());
     ExtensionService* service = extensions::ExtensionSystem::Get(
         browser()->profile())->extension_service();
     service->browser_event_router()->PageActionExecuted(
-        browser()->profile(), *action, tab_id, "", 0);
+        browser()->profile(), *action, tab_id, std::string(), 0);
     EXPECT_TRUE(catcher.GetNextResult());
   }
 
   {
     // Tell the extension to update the page action state again.
     ResultCatcher catcher;
     ui_test_utils::NavigateToURL(browser(),
         GURL(extension->GetResourceURL("update2.html")));
     ASSERT_TRUE(catcher.GetNextResult());
   }
@@ skipping 24 matching lines @@
 
   ASSERT_FALSE(page_action->HasPopup(tab_id));
 
   // Simulate the page action being clicked.  The resulting event should
   // install a page action popup.
   {
     ResultCatcher catcher;
     ExtensionService* service = extensions::ExtensionSystem::Get(
         browser()->profile())->extension_service();
     service->browser_event_router()->PageActionExecuted(
-        browser()->profile(), *page_action, tab_id, "", 1);
+        browser()->profile(), *page_action, tab_id, std::string(), 1);
     ASSERT_TRUE(catcher.GetNextResult());
   }
 
   ASSERT_TRUE(page_action->HasPopup(tab_id))
       << "Clicking on the page action should have caused a popup to be added.";
 
   ASSERT_STREQ("/a_popup.html",
                page_action->GetPopupUrl(tab_id).path().c_str());
 
   // Now change the popup from a_popup.html to a_second_popup.html .
@@ skipping 59 matching lines @@
 
   // Simulate the page action being clicked.
   {
     ResultCatcher catcher;
     int tab_id = ExtensionTabUtil::GetTabId(
         browser()->tab_strip_model()->GetActiveWebContents());
     ExtensionService* service = extensions::ExtensionSystem::Get(
         browser()->profile())->extension_service();
     ExtensionAction* page_action = GetPageAction(*extension);
     service->browser_event_router()->PageActionExecuted(
-        browser()->profile(), *page_action, tab_id, "", 1);
+        browser()->profile(), *page_action, tab_id, std::string(), 1);
     EXPECT_TRUE(catcher.GetNextResult());
   }
 }
 
 // Tests popups in page actions.
 // Flaky on the trybots. See http://crbug.com/96725.
 IN_PROC_BROWSER_TEST_F(PageActionApiTest, DISABLED_ShowPageActionPopup) {
   ASSERT_TRUE(RunExtensionTest("page_action/popup")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
@@ skipping 51 matching lines @@
   ASSERT_TRUE(page_action);
 
   {
     // Simulate the page action being clicked.
     ResultCatcher catcher;
     int tab_id = ExtensionTabUtil::GetTabId(
         browser()->tab_strip_model()->GetActiveWebContents());
     ExtensionService* service = extensions::ExtensionSystem::Get(
         browser()->profile())->extension_service();
     service->browser_event_router()->PageActionExecuted(
-        browser()->profile(), *page_action, tab_id, "", 0);
+        browser()->profile(), *page_action, tab_id, std::string(), 0);
     EXPECT_TRUE(catcher.GetNextResult());
   }
 
   WebContents* tab =
       browser()->tab_strip_model()->GetActiveWebContents();
   EXPECT_TRUE(tab != NULL);
 
   // Verify that the browser action turned the background color red.
   const std::string script =
       "window.domAutomationController.send(document.body.style."
       "backgroundColor);";
   std::string result;
-  const std::string frame_xpath = "";
-  EXPECT_TRUE(content::ExecuteScriptInFrameAndExtractString(tab,
-                                                            frame_xpath,
-                                                            script,
-                                                            &result));
+  const std::string frame_xpath;
+  EXPECT_TRUE(content::ExecuteScriptInFrameAndExtractString(
+      tab, frame_xpath, script, &result));
   EXPECT_EQ(result, "red");
 }
 
 }  // namespace
 }  // namespace extensions