Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/extensions/api/cookies/cookies_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Cookies API.
 
 #include "chrome/browser/extensions/api/cookies/cookies_api.h"
 
 #include <vector>
 
@@ skipping 185 matching lines @@
 }
 
 bool CookiesGetFunction::RunImpl() {
   parsed_args_ = Get::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parsed_args_.get());
 
   // Read/validate input parameters.
   if (!ParseUrl(parsed_args_->details.url, &url_, true))
     return false;
 
-  std::string store_id = parsed_args_->details.store_id.get() ?
-      *parsed_args_->details.store_id : "";
+  std::string store_id =
+      parsed_args_->details.store_id.get() ? *parsed_args_->details.store_id
+                                           : std::string();
   net::URLRequestContextGetter* store_context = NULL;
   if (!ParseStoreContext(&store_id, &store_context))
     return false;
   store_context_ = store_context;
   if (!parsed_args_->details.store_id.get())
     parsed_args_->details.store_id.reset(new std::string(store_id));
 
   store_context_ = store_context;
 
   bool rv = BrowserThread::PostTask(
@@ skipping 51 matching lines @@
 
 bool CookiesGetAllFunction::RunImpl() {
   parsed_args_ = GetAll::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parsed_args_.get());
 
   if (parsed_args_->details.url.get() &&
       !ParseUrl(*parsed_args_->details.url, &url_, false)) {
     return false;
   }
 
-  std::string store_id = parsed_args_->details.store_id.get() ?
-      *parsed_args_->details.store_id : "";
+  std::string store_id =
+      parsed_args_->details.store_id.get() ? *parsed_args_->details.store_id
+                                           : std::string();
   net::URLRequestContextGetter* store_context = NULL;
   if (!ParseStoreContext(&store_id, &store_context))
     return false;
   store_context_ = store_context;
   if (!parsed_args_->details.store_id.get())
     parsed_args_->details.store_id.reset(new std::string(store_id));
 
   bool rv = BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&CookiesGetAllFunction::GetAllCookiesOnIOThread, this));
@@ skipping 41 matching lines @@
 }
 
 bool CookiesSetFunction::RunImpl() {
   parsed_args_ = Set::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parsed_args_.get());
 
   // Read/validate input parameters.
   if (!ParseUrl(parsed_args_->details.url, &url_, true))
       return false;
 
-  std::string store_id = parsed_args_->details.store_id.get() ?
-      *parsed_args_->details.store_id : "";
+  std::string store_id =
+      parsed_args_->details.store_id.get() ? *parsed_args_->details.store_id
+                                           : std::string();
   net::URLRequestContextGetter* store_context = NULL;
   if (!ParseStoreContext(&store_id, &store_context))
     return false;
   store_context_ = store_context;
   if (!parsed_args_->details.store_id.get())
     parsed_args_->details.store_id.reset(new std::string(store_id));
 
   bool rv = BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&CookiesSetFunction::SetCookieOnIOThread, this));
@@ skipping 13 matching lines @@
   if (parsed_args_->details.expiration_date.get()) {
     // Time::FromDoubleT converts double time 0 to empty Time object. So we need
     // to do special handling here.
     expiration_time = (*parsed_args_->details.expiration_date == 0) ?
         base::Time::UnixEpoch() :
         base::Time::FromDoubleT(*parsed_args_->details.expiration_date);
   }
 
   cookie_monster->SetCookieWithDetailsAsync(
       url_,
-      parsed_args_->details.name.get() ? *parsed_args_->details.name : "",
-      parsed_args_->details.value.get() ? *parsed_args_->details.value : "",
-      parsed_args_->details.domain.get() ? *parsed_args_->details.domain : "",
-      parsed_args_->details.path.get() ? *parsed_args_->details.path : "",
+      parsed_args_->details.name.get() ? *parsed_args_->details.name
+                                       : std::string(),
+      parsed_args_->details.value.get() ? *parsed_args_->details.value
+                                        : std::string(),
+      parsed_args_->details.domain.get() ? *parsed_args_->details.domain
+                                         : std::string(),
+      parsed_args_->details.path.get() ? *parsed_args_->details.path
+                                       : std::string(),
       expiration_time,
-      parsed_args_->details.secure.get() ?
-          *parsed_args_->details.secure.get() :
-          false,
-      parsed_args_->details.http_only.get() ?
-          *parsed_args_->details.http_only :
-          false,
+      parsed_args_->details.secure.get() ? *parsed_args_->details.secure.get()
+                                         : false,
+      parsed_args_->details.http_only.get() ? *parsed_args_->details.http_only
+                                            : false,
       base::Bind(&CookiesSetFunction::PullCookie, this));
 }
 
 void CookiesSetFunction::PullCookie(bool set_cookie_result) {
   // Pull the newly set cookie.
   net::CookieMonster* cookie_monster =
       store_context_->GetURLRequestContext()->cookie_store()->
       GetCookieMonster();
   success_ = set_cookie_result;
   cookies_helpers::GetCookieListFromStore(
       cookie_monster, url_,
       base::Bind(&CookiesSetFunction::PullCookieCallback, this));
 }
 
 void CookiesSetFunction::PullCookieCallback(
     const net::CookieList& cookie_list) {
   net::CookieList::const_iterator it;
   for (it = cookie_list.begin(); it != cookie_list.end(); ++it) {
     // Return the first matching cookie. Relies on the fact that the
     // CookieMonster returns them in canonical order (longest path, then
     // earliest creation time).
-    std::string name = parsed_args_->details.name.get() ?
-        *parsed_args_->details.name : "";
+    std::string name =
+        parsed_args_->details.name.get() ? *parsed_args_->details.name
+                                         : std::string();
     if (it->Name() == name) {
       scoped_ptr<Cookie> cookie(
           cookies_helpers::CreateCookie(*it, *parsed_args_->details.store_id));
       results_ = Set::Results::Create(*cookie);
       break;
     }
   }
 
   bool rv = BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&CookiesSetFunction::RespondOnUIThread, this));
   DCHECK(rv);
 }
 
 void CookiesSetFunction::RespondOnUIThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!success_) {
-    std::string name = parsed_args_->details.name.get() ?
-        *parsed_args_->details.name : "";
-    error_ = ErrorUtils::FormatErrorMessage(
-        keys::kCookieSetFailedError, name);
+    std::string name =
+        parsed_args_->details.name.get() ? *parsed_args_->details.name
+                                         : std::string();
+    error_ = ErrorUtils::FormatErrorMessage(keys::kCookieSetFailedError, name);
   }
   SendResponse(success_);
 }
 
 CookiesRemoveFunction::CookiesRemoveFunction() {
 }
 
 CookiesRemoveFunction::~CookiesRemoveFunction() {
 }
 
 bool CookiesRemoveFunction::RunImpl() {
   parsed_args_ = Remove::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parsed_args_.get());
 
   // Read/validate input parameters.
   if (!ParseUrl(parsed_args_->details.url, &url_, true))
     return false;
 
-  std::string store_id = parsed_args_->details.store_id.get() ?
-      *parsed_args_->details.store_id : "";
+  std::string store_id =
+      parsed_args_->details.store_id.get() ? *parsed_args_->details.store_id
+                                           : std::string();
   net::URLRequestContextGetter* store_context = NULL;
   if (!ParseStoreContext(&store_id, &store_context))
     return false;
   store_context_ = store_context;
   if (!parsed_args_->details.store_id.get())
     parsed_args_->details.store_id.reset(new std::string(store_id));
 
   // Pass the work off to the IO thread.
   bool rv = BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
@@ skipping 102 matching lines @@
   return &g_factory.Get();
 }
 
 void CookiesAPI::OnListenerAdded(
     const extensions::EventListenerInfo& details) {
   cookies_event_router_.reset(new CookiesEventRouter(profile_));
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }
 
 }  // namespace extensions