chrome/browser/content_settings/mock_settings_observer.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/content_settings/mock_settings_observer.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/devtools/browser_list_tabcontents_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/content_settings/mock_settings_observer.h"	5 #include "chrome/browser/content_settings/mock_settings_observer.h"

6	6

7 #include "chrome/browser/content_settings/content_settings_details.h"	7 #include "chrome/browser/content_settings/content_settings_details.h"

8 #include "chrome/browser/content_settings/host_content_settings_map.h"	8 #include "chrome/browser/content_settings/host_content_settings_map.h"

9 #include "chrome/common/chrome_notification_types.h"	9 #include "chrome/common/chrome_notification_types.h"

10 #include "content/public/browser/notification_service.h"	10 #include "content/public/browser/notification_service.h"

(...skipping 17 matching lines...) Expand all Loading...
28 content::Details<ContentSettingsDetails>(details).ptr();	28 content::Details<ContentSettingsDetails>(details).ptr();

29 OnContentSettingsChanged(map,	29 OnContentSettingsChanged(map,

30 settings_details->type(),	30 settings_details->type(),

31 settings_details->update_all_types(),	31 settings_details->update_all_types(),

32 settings_details->primary_pattern(),	32 settings_details->primary_pattern(),

33 settings_details->secondary_pattern(),	33 settings_details->secondary_pattern(),

34 settings_details->update_all());	34 settings_details->update_all());

35 // This checks that calling a Get function from an observer doesn't	35 // This checks that calling a Get function from an observer doesn't

36 // deadlock.	36 // deadlock.

37 GURL url("http://random-hostname.com/");	37 GURL url("http://random-hostname.com/");

38 map->GetContentSetting(url, url, CONTENT_SETTINGS_TYPE_IMAGES, "");	38 map->GetContentSetting(url, url, CONTENT_SETTINGS_TYPE_IMAGES, std::string());

39 }	39 }

OLD	NEW