Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/content_settings/content_settings_policy_provider_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/content_settings_policy_provider.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 132 matching lines @@
                         value);
 
   PolicyProvider provider(prefs);
 
   ContentSettingsPattern yt_url_pattern =
       ContentSettingsPattern::FromString("www.youtube.com");
   GURL youtube_url("http://www.youtube.com");
   GURL google_url("http://mail.google.com");
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            GetContentSetting(
-                &provider, youtube_url, youtube_url,
-                CONTENT_SETTINGS_TYPE_COOKIES, "", false));
+            GetContentSetting(&provider,
+                              youtube_url,
+                              youtube_url,
+                              CONTENT_SETTINGS_TYPE_COOKIES,
+                              std::string(),
+                              false));
   EXPECT_EQ(NULL,
-            GetContentSettingValue(
-                &provider, youtube_url, youtube_url,
-                CONTENT_SETTINGS_TYPE_COOKIES, "", false));
+            GetContentSettingValue(&provider,
+                                   youtube_url,
+                                   youtube_url,
+                                   CONTENT_SETTINGS_TYPE_COOKIES,
+                                   std::string(),
+                                   false));
 
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(
-                &provider, google_url, google_url,
-                CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&provider,
+                              google_url,
+                              google_url,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   scoped_ptr<Value> value_ptr(
-      GetContentSettingValue(
-          &provider, google_url, google_url,
-          CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+      GetContentSettingValue(&provider,
+                             google_url,
+                             google_url,
+                             CONTENT_SETTINGS_TYPE_IMAGES,
+                             std::string(),
+                             false));
 
   int int_value = -1;
   value_ptr->GetAsInteger(&int_value);
   EXPECT_EQ(CONTENT_SETTING_BLOCK, IntToContentSetting(int_value));
 
   // The PolicyProvider does not allow setting content settings as they are
   // enforced via policies and not set by the user or extension. So a call to
   // SetWebsiteSetting does nothing.
   scoped_ptr<base::Value> value_block(
       Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
-  bool owned = provider.SetWebsiteSetting(
-      yt_url_pattern,
-      yt_url_pattern,
-      CONTENT_SETTINGS_TYPE_COOKIES,
-      "",
-      value_block.get());
+  bool owned = provider.SetWebsiteSetting(yt_url_pattern,
+                                          yt_url_pattern,
+                                          CONTENT_SETTINGS_TYPE_COOKIES,
+                                          std::string(),
+                                          value_block.get());
   EXPECT_FALSE(owned);
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            GetContentSetting(
-                &provider, youtube_url, youtube_url,
-                CONTENT_SETTINGS_TYPE_COOKIES, "", false));
+            GetContentSetting(&provider,
+                              youtube_url,
+                              youtube_url,
+                              CONTENT_SETTINGS_TYPE_COOKIES,
+                              std::string(),
+                              false));
 
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, ResourceIdentifier) {
   TestingProfile profile;
   TestingPrefServiceSyncable* prefs = profile.GetTestingPrefService();
 
   ListValue* value = new ListValue();
   value->Append(Value::CreateStringValue("[*.]google.com"));
   prefs->SetManagedPref(prefs::kManagedPluginsAllowedForUrls,
                         value);
 
   PolicyProvider provider(prefs);
 
   GURL youtube_url("http://www.youtube.com");
   GURL google_url("http://mail.google.com");
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
             GetContentSetting(
                 &provider, youtube_url, youtube_url,
                 CONTENT_SETTINGS_TYPE_PLUGINS, "someplugin", false));
 
   // There is currently no policy support for resource content settings.
   // Resource identifiers are simply ignored by the PolicyProvider.
   EXPECT_EQ(CONTENT_SETTING_ALLOW,
-            GetContentSetting(
-                &provider, google_url, google_url,
-                CONTENT_SETTINGS_TYPE_PLUGINS, "", false));
+            GetContentSetting(&provider,
+                              google_url,
+                              google_url,
+                              CONTENT_SETTINGS_TYPE_PLUGINS,
+                              std::string(),
+                              false));
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
             GetContentSetting(
                 &provider, google_url, google_url,
                 CONTENT_SETTINGS_TYPE_PLUGINS, "someplugin", false));
 
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PolicyProviderTest, AutoSelectCertificateList) {
   TestingProfile profile;
   TestingPrefServiceSyncable* prefs = profile.GetTestingPrefService();
 
   PolicyProvider provider(prefs);
   GURL google_url("https://mail.google.com");
   // Tests the default setting for auto selecting certificates
-  EXPECT_EQ(NULL,
-            GetContentSettingValue(
-                &provider, google_url, google_url,
-                CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, "", false));
+  EXPECT_EQ(
+      NULL,
+      GetContentSettingValue(&provider,
+                             google_url,
+                             google_url,
+                             CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
+                             std::string(),
+                             false));
 
   // Set the content settings pattern list for origins to auto select
   // certificates.
   std::string pattern_str("\"pattern\":\"[*.]google.com\"");
   std::string filter_str("\"filter\":{\"ISSUER\":{\"CN\":\"issuer name\"}}");
   ListValue* value = new ListValue();
   value->Append(Value::CreateStringValue(
       "{" + pattern_str + "," + filter_str + "}"));
   prefs->SetManagedPref(prefs::kManagedAutoSelectCertificateForUrls,
                         value);
   GURL youtube_url("https://www.youtube.com");
-  EXPECT_EQ(NULL,
-            GetContentSettingValue(
-                &provider, youtube_url, youtube_url,
-                CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, "", false));
-  scoped_ptr<Value> cert_filter(GetContentSettingValue(
-      &provider, google_url, google_url,
-      CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, "", false));
+  EXPECT_EQ(
+      NULL,
+      GetContentSettingValue(&provider,
+                             youtube_url,
+                             youtube_url,
+                             CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
+                             std::string(),
+                             false));
+  scoped_ptr<Value> cert_filter(
+      GetContentSettingValue(&provider,
+                             google_url,
+                             google_url,
+                             CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE,
+                             std::string(),
+                             false));
 
   ASSERT_EQ(Value::TYPE_DICTIONARY, cert_filter->GetType());
   DictionaryValue* dict_value =
       static_cast<DictionaryValue*>(cert_filter.get());
   std::string actual_common_name;
   ASSERT_TRUE(dict_value->GetString("ISSUER.CN", &actual_common_name));
   EXPECT_EQ("issuer name", actual_common_name);
   provider.ShutdownOnUIThread();
 }
 
 }  // namespace content_settings