Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/autofill/autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 487 matching lines @@
     LOG(WARNING) << "Typing 'M' to bring up the Autofill popup.";
     SendKeyToPageAndWait(ui::VKEY_M);
 
     // Press the down arrow to select the suggestion and preview the autofilled
     // form.
     LOG(WARNING) << "Simulating down arrow press to initiate Autofill preview.";
     SendKeyToPopupAndWait(ui::VKEY_DOWN);
 
     // The previewed values should not be accessible to JavaScript.
     ExpectFieldValue("firstname", "M");
-    ExpectFieldValue("lastname", "");
-    ExpectFieldValue("address1", "");
-    ExpectFieldValue("address2", "");
-    ExpectFieldValue("city", "");
-    ExpectFieldValue("state", "");
-    ExpectFieldValue("zip", "");
-    ExpectFieldValue("country", "");
-    ExpectFieldValue("phone", "");
+    ExpectFieldValue("lastname", std::string());
+    ExpectFieldValue("address1", std::string());
+    ExpectFieldValue("address2", std::string());
+    ExpectFieldValue("city", std::string());
+    ExpectFieldValue("state", std::string());
+    ExpectFieldValue("zip", std::string());
+    ExpectFieldValue("country", std::string());
+    ExpectFieldValue("phone", std::string());
     // TODO(isherman): It would be nice to test that the previewed values are
     // displayed: http://crbug.com/57220
 
     // Press Enter to accept the autofill suggestions.
     LOG(WARNING) << "Simulating Return press to fill the form.";
     SendKeyToPopupAndWait(ui::VKEY_RETURN);
 
     // The form should be filled.
     ExpectFilledTestForm();
   }
@@ skipping 209 matching lines @@
            " <option value=\"\" selected=\"yes\">--</option>"
            " <option value=\"CA\">Canada</option>"
            " <option value=\"US\">United States</option>"
            " </select><br>"
            "<label for=\"phone\">Phone number:</label>"
            " <input type=\"text\" id=\"phone\"><br>"
            "</form>")));
 
   // Invoke Autofill.
   TryBasicFormFill();
-  ExpectFieldValue("state_freeform", "");
+  ExpectFieldValue("state_freeform", std::string());
 }
 
 // http://crbug.com/150084
 #if defined(OS_MACOSX)
 #define MAYBE_AutofillFormWithNonAutofillableField \
     AutofillFormWithNonAutofillableField
 #else
 #define MAYBE_AutofillFormWithNonAutofillableField \
     DISABLED_AutofillFormWithNonAutofillableField
 #endif
@@ skipping 544 matching lines @@
   ExpectFieldValue("ADDRESS_HOME_STATE", "CA");
   ExpectFieldValue("ADDRESS_HOME_ZIP", "95110");
   ExpectFieldValue("PHONE_HOME_WHOLE_NUMBER", "14085554567");
   ExpectFieldValue("PHONE_HOME_CITY_CODE-1", "408");
   ExpectFieldValue("PHONE_HOME_CITY_CODE-2", "408");
   ExpectFieldValue("PHONE_HOME_NUMBER", "5554567");
   ExpectFieldValue("PHONE_HOME_NUMBER_3-1", "555");
   ExpectFieldValue("PHONE_HOME_NUMBER_3-2", "555");
   ExpectFieldValue("PHONE_HOME_NUMBER_4-1", "4567");
   ExpectFieldValue("PHONE_HOME_NUMBER_4-2", "4567");
-  ExpectFieldValue("PHONE_HOME_EXT-1", "");
-  ExpectFieldValue("PHONE_HOME_EXT-2", "");
+  ExpectFieldValue("PHONE_HOME_EXT-1", std::string());
+  ExpectFieldValue("PHONE_HOME_EXT-2", std::string());
   ExpectFieldValue("PHONE_HOME_COUNTRY_CODE-1", "1");
 }
 
 // Test profile is saved if phone number is valid in selected country.
 // The data file contains two profiles with valid phone numbers and two
 // profiles with invalid phone numbers from their respective country.
 // DISABLED: http://crbug.com/150084
 IN_PROC_BROWSER_TEST_F(AutofillTest,
                        DISABLED_ProfileSavedWithValidCountryPhone) {
   ASSERT_TRUE(test_server()->Start());
@@ skipping 118 matching lines @@
   profile.SetRawInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("CA"));
   profile.SetRawInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("95110"));
   profile.SetRawInfo(COMPANY_NAME, ASCIIToUTF16("Company X"));
   profile.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, ASCIIToUTF16("408-871-4567"));
   SetProfile(profile);
 
   GURL url = test_server()->GetURL("files/autofill/read_only_field_test.html");
   ui_test_utils::NavigateToURL(browser(), url);
   PopulateForm("firstname");
 
-  ExpectFieldValue("email", "");
+  ExpectFieldValue("email", std::string());
   ExpectFieldValue("address", addr_line1);
 }
 
 // http://crbug.com/150084
 #if defined(OS_MACOSX)
 #define MAYBE_FormFillableOnReset FormFillableOnReset
 #else
 #define MAYBE_FormFillableOnReset DISABLED_FormFillableOnReset
 #endif
 // Test form is fillable from a profile after form was reset.
@@ skipping 251 matching lines @@
 // TODO(isherman): this looks redundant, consider removing.
 // DISABLED: http://crbug.com/150084
 IN_PROC_BROWSER_TEST_F(AutofillTest,
                        DISABLED_MergeAggregatedDuplicatedProfiles) {
   int num_of_profiles =
       AggregateProfilesIntoAutofillPrefs("dataset_no_address.txt");
 
   ASSERT_GT(num_of_profiles,
             static_cast<int>(personal_data_manager()->GetProfiles().size()));
 }