Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: base/vlog_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/about_flags_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/vlog.h" 5 #include "base/vlog.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/third_party/dynamic_annotations/dynamic_annotations.h" 9 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
10 #include "base/time.h" 10 #include "base/time.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 namespace logging { 13 namespace logging {
14 14
15 namespace { 15 namespace {
16 16
17 TEST(VlogTest, NoVmodule) { 17 TEST(VlogTest, NoVmodule) {
18 int min_log_level = 0; 18 int min_log_level = 0;
19 EXPECT_EQ(0, VlogInfo("", "", &min_log_level).GetVlogLevel("test1")); 19 EXPECT_EQ(0,
20 EXPECT_EQ(0, VlogInfo("0", "", &min_log_level).GetVlogLevel("test2")); 20 VlogInfo(std::string(), std::string(), &min_log_level)
21 EXPECT_EQ(0, VlogInfo("blah", "", &min_log_level).GetVlogLevel("test3")); 21 .GetVlogLevel("test1"));
22 EXPECT_EQ(0, VlogInfo("0blah1", "", &min_log_level).GetVlogLevel("test4")); 22 EXPECT_EQ(0,
23 EXPECT_EQ(1, VlogInfo("1", "", &min_log_level).GetVlogLevel("test5")); 23 VlogInfo("0", std::string(), &min_log_level).GetVlogLevel("test2"));
24 EXPECT_EQ(5, VlogInfo("5", "", &min_log_level).GetVlogLevel("test6")); 24 EXPECT_EQ(
25 0, VlogInfo("blah", std::string(), &min_log_level).GetVlogLevel("test3"));
26 EXPECT_EQ(
27 0,
28 VlogInfo("0blah1", std::string(), &min_log_level).GetVlogLevel("test4"));
29 EXPECT_EQ(1,
30 VlogInfo("1", std::string(), &min_log_level).GetVlogLevel("test5"));
31 EXPECT_EQ(5,
32 VlogInfo("5", std::string(), &min_log_level).GetVlogLevel("test6"));
25 } 33 }
26 34
27 TEST(VlogTest, MatchVlogPattern) { 35 TEST(VlogTest, MatchVlogPattern) {
28 // Degenerate cases. 36 // Degenerate cases.
29 EXPECT_TRUE(MatchVlogPattern("", "")); 37 EXPECT_TRUE(MatchVlogPattern("", ""));
30 EXPECT_TRUE(MatchVlogPattern("", "****")); 38 EXPECT_TRUE(MatchVlogPattern("", "****"));
31 EXPECT_FALSE(MatchVlogPattern("", "x")); 39 EXPECT_FALSE(MatchVlogPattern("", "x"));
32 EXPECT_FALSE(MatchVlogPattern("x", "")); 40 EXPECT_FALSE(MatchVlogPattern("x", ""));
33 41
34 // Basic. 42 // Basic.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 EXPECT_EQ(0, vlog_info.GetVlogLevel("baz.h")); 93 EXPECT_EQ(0, vlog_info.GetVlogLevel("baz.h"));
86 EXPECT_EQ(0, vlog_info.GetVlogLevel("/another/path/to/qux.h")); 94 EXPECT_EQ(0, vlog_info.GetVlogLevel("/another/path/to/qux.h"));
87 EXPECT_EQ(1, vlog_info.GetVlogLevel("/path/to/quux")); 95 EXPECT_EQ(1, vlog_info.GetVlogLevel("/path/to/quux"));
88 EXPECT_EQ(5, vlog_info.GetVlogLevel("c:\\path/to/corge.ext.h")); 96 EXPECT_EQ(5, vlog_info.GetVlogLevel("c:\\path/to/corge.ext.h"));
89 } 97 }
90 98
91 TEST(VlogTest, VmoduleDirs) { 99 TEST(VlogTest, VmoduleDirs) {
92 const char kVModuleSwitch[] = 100 const char kVModuleSwitch[] =
93 "foo/bar.cc=1,baz\\*\\qux.cc=2,*quux/*=3,*/*-inl.h=4"; 101 "foo/bar.cc=1,baz\\*\\qux.cc=2,*quux/*=3,*/*-inl.h=4";
94 int min_log_level = 0; 102 int min_log_level = 0;
95 VlogInfo vlog_info("", kVModuleSwitch, &min_log_level); 103 VlogInfo vlog_info(std::string(), kVModuleSwitch, &min_log_level);
96 EXPECT_EQ(0, vlog_info.GetVlogLevel("/foo/bar.cc")); 104 EXPECT_EQ(0, vlog_info.GetVlogLevel("/foo/bar.cc"));
97 EXPECT_EQ(0, vlog_info.GetVlogLevel("bar.cc")); 105 EXPECT_EQ(0, vlog_info.GetVlogLevel("bar.cc"));
98 EXPECT_EQ(1, vlog_info.GetVlogLevel("foo/bar.cc")); 106 EXPECT_EQ(1, vlog_info.GetVlogLevel("foo/bar.cc"));
99 107
100 EXPECT_EQ(0, vlog_info.GetVlogLevel("baz/grault/qux.h")); 108 EXPECT_EQ(0, vlog_info.GetVlogLevel("baz/grault/qux.h"));
101 EXPECT_EQ(0, vlog_info.GetVlogLevel("/baz/grault/qux.cc")); 109 EXPECT_EQ(0, vlog_info.GetVlogLevel("/baz/grault/qux.cc"));
102 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz/grault/qux.cc")); 110 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz/grault/qux.cc"));
103 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz/grault/blah/qux.cc")); 111 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz/grault/blah/qux.cc"));
104 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz\\grault\\qux.cc")); 112 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz\\grault\\qux.cc"));
105 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz\\grault//blah\\qux.cc")); 113 EXPECT_EQ(2, vlog_info.GetVlogLevel("baz\\grault//blah\\qux.cc"));
106 114
107 EXPECT_EQ(0, vlog_info.GetVlogLevel("/foo/bar/baz/quux.cc")); 115 EXPECT_EQ(0, vlog_info.GetVlogLevel("/foo/bar/baz/quux.cc"));
108 EXPECT_EQ(3, vlog_info.GetVlogLevel("/foo/bar/baz/quux/grault.cc")); 116 EXPECT_EQ(3, vlog_info.GetVlogLevel("/foo/bar/baz/quux/grault.cc"));
109 EXPECT_EQ(3, vlog_info.GetVlogLevel("/foo\\bar/baz\\quux/grault.cc")); 117 EXPECT_EQ(3, vlog_info.GetVlogLevel("/foo\\bar/baz\\quux/grault.cc"));
110 118
111 EXPECT_EQ(0, vlog_info.GetVlogLevel("foo/bar/test-inl.cc")); 119 EXPECT_EQ(0, vlog_info.GetVlogLevel("foo/bar/test-inl.cc"));
112 EXPECT_EQ(4, vlog_info.GetVlogLevel("foo/bar/test-inl.h")); 120 EXPECT_EQ(4, vlog_info.GetVlogLevel("foo/bar/test-inl.h"));
113 EXPECT_EQ(4, vlog_info.GetVlogLevel("foo/bar/baz/blah-inl.h")); 121 EXPECT_EQ(4, vlog_info.GetVlogLevel("foo/bar/baz/blah-inl.h"));
114 } 122 }
115 123
116 } // namespace 124 } // namespace
117 125
118 } // namespace logging 126 } // namespace logging
OLDNEW
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/about_flags_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698