Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: base/prefs/pref_service_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/pref_change_registrar_unittest.cc ('k') | base/process_util_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/prefs/json_pref_store.h" 7 #include "base/prefs/json_pref_store.h"
8 #include "base/prefs/mock_pref_change_callback.h" 8 #include "base/prefs/mock_pref_change_callback.h"
9 #include "base/prefs/pref_change_registrar.h" 9 #include "base/prefs/pref_change_registrar.h"
10 #include "base/prefs/pref_registry_simple.h" 10 #include "base/prefs/pref_registry_simple.h"
(...skipping 27 matching lines...) Expand all
38 prefs.SetString(pref_name, new_pref_value); 38 prefs.SetString(pref_name, new_pref_value);
39 Mock::VerifyAndClearExpectations(&obs); 39 Mock::VerifyAndClearExpectations(&obs);
40 40
41 // Setting the pref to the same value should not set the pref value a second 41 // Setting the pref to the same value should not set the pref value a second
42 // time. 42 // time.
43 EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0); 43 EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0);
44 prefs.SetString(pref_name, new_pref_value); 44 prefs.SetString(pref_name, new_pref_value);
45 Mock::VerifyAndClearExpectations(&obs); 45 Mock::VerifyAndClearExpectations(&obs);
46 46
47 // Clearing the pref should cause the pref to fire. 47 // Clearing the pref should cause the pref to fire.
48 const StringValue expected_default_value(""); 48 const StringValue expected_default_value((std::string()));
49 obs.Expect(pref_name, &expected_default_value); 49 obs.Expect(pref_name, &expected_default_value);
50 prefs.ClearPref(pref_name); 50 prefs.ClearPref(pref_name);
51 Mock::VerifyAndClearExpectations(&obs); 51 Mock::VerifyAndClearExpectations(&obs);
52 52
53 // Clearing the pref again should not cause the pref to fire. 53 // Clearing the pref again should not cause the pref to fire.
54 EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0); 54 EXPECT_CALL(obs, OnPreferenceChanged(_)).Times(0);
55 prefs.ClearPref(pref_name); 55 prefs.ClearPref(pref_name);
56 Mock::VerifyAndClearExpectations(&obs); 56 Mock::VerifyAndClearExpectations(&obs);
57 } 57 }
58 58
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 307
308 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0); 308 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
309 prefs_.Set(kName, new_value); 309 prefs_.Set(kName, new_value);
310 Mock::VerifyAndClearExpectations(&observer_); 310 Mock::VerifyAndClearExpectations(&observer_);
311 311
312 ListValue empty; 312 ListValue empty;
313 observer_.Expect(kName, &empty); 313 observer_.Expect(kName, &empty);
314 prefs_.Set(kName, empty); 314 prefs_.Set(kName, empty);
315 Mock::VerifyAndClearExpectations(&observer_); 315 Mock::VerifyAndClearExpectations(&observer_);
316 } 316 }
OLDNEW
« no previous file with comments | « base/prefs/pref_change_registrar_unittest.cc ('k') | base/process_util_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698