Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: base/metrics/field_trial_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/metrics/field_trial.cc ('k') | base/metrics/statistics_recorder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/field_trial.h" 5 #include "base/metrics/field_trial.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/rand_util.h" 8 #include "base/rand_util.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/stringprintf.h" 10 #include "base/stringprintf.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 const char* name2 = "name 2 test"; 79 const char* name2 = "name 2 test";
80 EXPECT_FALSE(FieldTrialList::Find(name1)); 80 EXPECT_FALSE(FieldTrialList::Find(name1));
81 EXPECT_FALSE(FieldTrialList::Find(name2)); 81 EXPECT_FALSE(FieldTrialList::Find(name2));
82 82
83 FieldTrial* trial1 = FieldTrialList::FactoryGetFieldTrial( 83 FieldTrial* trial1 = FieldTrialList::FactoryGetFieldTrial(
84 name1, 10, "default name 1 test", next_year_, 12, 31, NULL); 84 name1, 10, "default name 1 test", next_year_, 12, 31, NULL);
85 EXPECT_EQ(FieldTrial::kNotFinalized, trial1->group_); 85 EXPECT_EQ(FieldTrial::kNotFinalized, trial1->group_);
86 EXPECT_EQ(name1, trial1->trial_name()); 86 EXPECT_EQ(name1, trial1->trial_name());
87 EXPECT_EQ("", trial1->group_name_internal()); 87 EXPECT_EQ("", trial1->group_name_internal());
88 88
89 trial1->AppendGroup("", 7); 89 trial1->AppendGroup(std::string(), 7);
90 90
91 EXPECT_EQ(trial1, FieldTrialList::Find(name1)); 91 EXPECT_EQ(trial1, FieldTrialList::Find(name1));
92 EXPECT_FALSE(FieldTrialList::Find(name2)); 92 EXPECT_FALSE(FieldTrialList::Find(name2));
93 93
94 FieldTrial* trial2 = FieldTrialList::FactoryGetFieldTrial( 94 FieldTrial* trial2 = FieldTrialList::FactoryGetFieldTrial(
95 name2, 10, "default name 2 test", next_year_, 12, 31, NULL); 95 name2, 10, "default name 2 test", next_year_, 12, 31, NULL);
96 EXPECT_EQ(FieldTrial::kNotFinalized, trial2->group_); 96 EXPECT_EQ(FieldTrial::kNotFinalized, trial2->group_);
97 EXPECT_EQ(name2, trial2->trial_name()); 97 EXPECT_EQ(name2, trial2->trial_name());
98 EXPECT_EQ("", trial2->group_name_internal()); 98 EXPECT_EQ("", trial2->group_name_internal());
99 99
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 int group_count(10); 214 int group_count(10);
215 215
216 int default_group_number = -1; 216 int default_group_number = -1;
217 FieldTrial* trial = FieldTrialList::FactoryGetFieldTrial( 217 FieldTrial* trial = FieldTrialList::FactoryGetFieldTrial(
218 name, group_count, default_group_name, next_year_, 12, 31, 218 name, group_count, default_group_name, next_year_, 12, 31,
219 &default_group_number); 219 &default_group_number);
220 int winner_index(-2); 220 int winner_index(-2);
221 std::string winner_name; 221 std::string winner_name;
222 222
223 for (int i = 1; i <= group_count; ++i) { 223 for (int i = 1; i <= group_count; ++i) {
224 int might_win = trial->AppendGroup("", 1); 224 int might_win = trial->AppendGroup(std::string(), 1);
225 225
226 // Because we keep appending groups, we want to see if the last group that 226 // Because we keep appending groups, we want to see if the last group that
227 // was added has been assigned or not. 227 // was added has been assigned or not.
228 if (trial->group_ == might_win) { 228 if (trial->group_ == might_win) {
229 EXPECT_EQ(-2, winner_index); 229 EXPECT_EQ(-2, winner_index);
230 winner_index = might_win; 230 winner_index = might_win;
231 StringAppendF(&winner_name, "%d", might_win); 231 StringAppendF(&winner_name, "%d", might_win);
232 EXPECT_EQ(winner_name, trial->group_name()); 232 EXPECT_EQ(winner_name, trial->group_name());
233 } 233 }
234 } 234 }
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 837
838 FieldTrial* trial = 838 FieldTrial* trial =
839 FieldTrialList::FactoryGetFieldTrial( 839 FieldTrialList::FactoryGetFieldTrial(
840 kTrialName, kProbability, kDefaultGroupName, 840 kTrialName, kProbability, kDefaultGroupName,
841 FieldTrialList::kNoExpirationYear, 1, 1, NULL); 841 FieldTrialList::kNoExpirationYear, 1, 1, NULL);
842 trial->AppendGroup(kGroupName, kProbability); 842 trial->AppendGroup(kGroupName, kProbability);
843 EXPECT_EQ(kGroupName, trial->group_name()); 843 EXPECT_EQ(kGroupName, trial->group_name());
844 } 844 }
845 845
846 } // namespace base 846 } // namespace base
OLDNEW
« no previous file with comments | « base/metrics/field_trial.cc ('k') | base/metrics/statistics_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698