chrome/browser/extensions/api/dial/dial_device_data_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/dial/dial_device_data_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« base/nix/mime_util_xdg.cc ('K') | « chrome/browser/extensions/api/developer_private/entry_picker.cc ('k') | chrome/browser/extensions/api/dial/dial_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/dial/dial_device_data.h"	5 #include "chrome/browser/extensions/api/dial/dial_device_data.h"

6 #include "chrome/common/extensions/api/dial.h"	6 #include "chrome/common/extensions/api/dial.h"

7 #include "testing/gtest/include/gtest/gtest.h"	7 #include "testing/gtest/include/gtest/gtest.h"

8	8

9 namespace extensions {	9 namespace extensions {

10	10

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(	89 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

90 GURL("http://some.device.com/dd.xml")));	90 GURL("http://some.device.com/dd.xml")));

91 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(	91 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

92 GURL("https://some.device.com/dd.xml")));	92 GURL("https://some.device.com/dd.xml")));

93 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(	93 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

94 GURL("http://192.168.1.1:1234/dd.xml")));	94 GURL("http://192.168.1.1:1234/dd.xml")));

95 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(	95 EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

96 GURL("https://192.168.1.1:1234/dd.xml")));	96 GURL("https://192.168.1.1:1234/dd.xml")));

97	97

98 EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(GURL()));	98 EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(GURL()));

99 EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(GURL("")));	99 EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(GURL(std::string())));

100 EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(	100 EXPECT_FALSE(

101 GURL("file://path/to/file")));	101 DialDeviceData::IsDeviceDescriptionUrl(GURL("file://path/to/file")));

102 }	102 }

103	103

104 } // namespace extensions	104 } // namespace extensions

OLD	NEW