Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/content_settings_pref_provider.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 103 matching lines @@
                                       ContentSettingsPattern::Wildcard(),
                                       CONTENT_SETTINGS_TYPE_IMAGES,
                                       ""));
 
   pref_content_settings_provider.AddObserver(&mock_observer);
 
   pref_content_settings_provider.SetWebsiteSetting(
       pattern,
       ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
+      std::string(),
       Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
 
   pref_content_settings_provider.ShutdownOnUIThread();
 }
 
 // Test for regression in which the PrefProvider modified the user pref store
 // of the OTR unintentionally: http://crbug.com/74466.
 TEST_F(PrefProviderTest, Incognito) {
   PersistentPrefStore* user_prefs = new TestingPrefStore();
   OverlayUserPrefStore* otr_user_prefs =
@@ skipping 24 matching lines @@
   profile->SetOffTheRecordProfile(otr_profile);
 
   PrefProvider pref_content_settings_provider(regular_prefs, false);
   PrefProvider pref_content_settings_provider_incognito(otr_prefs, true);
   ContentSettingsPattern pattern =
       ContentSettingsPattern::FromString("[*.]example.com");
   pref_content_settings_provider.SetWebsiteSetting(
       pattern,
       pattern,
       CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
+      std::string(),
       Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
 
   GURL host("http://example.com/");
   // The value should of course be visible in the regular PrefProvider.
   EXPECT_EQ(CONTENT_SETTING_ALLOW,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host, host, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host,
+                              host,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   // And also in the OTR version.
   EXPECT_EQ(CONTENT_SETTING_ALLOW,
-            GetContentSetting(
-                &pref_content_settings_provider_incognito,
-                host, host, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider_incognito,
+                              host,
+                              host,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   // But the value should not be overridden in the OTR user prefs accidentally.
   EXPECT_FALSE(otr_user_prefs->IsSetInOverlay(
       prefs::kContentSettingsPatternPairs));
 
   pref_content_settings_provider.ShutdownOnUIThread();
   pref_content_settings_provider_incognito.ShutdownOnUIThread();
 }
 
 TEST_F(PrefProviderTest, GetContentSettingsValue) {
   TestingProfile testing_profile;
   PrefProvider provider(testing_profile.GetPrefs(), false);
 
   GURL primary_url("http://example.com/");
   ContentSettingsPattern primary_pattern =
       ContentSettingsPattern::FromString("[*.]example.com");
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            GetContentSetting(&provider, primary_url, primary_url,
-                              CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&provider,
+                              primary_url,
+                              primary_url,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
 
   EXPECT_EQ(NULL,
-            GetContentSettingValue(
-                &provider, primary_url, primary_url,
-                CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSettingValue(&provider,
+                                   primary_url,
+                                   primary_url,
+                                   CONTENT_SETTINGS_TYPE_IMAGES,
+                                   std::string(),
+                                   false));
 
-  provider.SetWebsiteSetting(
-      primary_pattern,
-      primary_pattern,
-      CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
-      Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+  provider.SetWebsiteSetting(primary_pattern,
+                             primary_pattern,
+                             CONTENT_SETTINGS_TYPE_IMAGES,
+                             std::string(),
+                             Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(&provider, primary_url, primary_url,
-                              CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&provider,
+                              primary_url,
+                              primary_url,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   scoped_ptr<Value> value_ptr(
-      GetContentSettingValue(&provider, primary_url, primary_url,
-                             CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+      GetContentSettingValue(&provider,
+                             primary_url,
+                             primary_url,
+                             CONTENT_SETTINGS_TYPE_IMAGES,
+                             std::string(),
+                             false));
   int int_value = -1;
   value_ptr->GetAsInteger(&int_value);
   EXPECT_EQ(CONTENT_SETTING_BLOCK, IntToContentSetting(int_value));
 
   provider.SetWebsiteSetting(primary_pattern,
                              primary_pattern,
                              CONTENT_SETTINGS_TYPE_IMAGES,
-                             "",
+                             std::string(),
                              NULL);
   EXPECT_EQ(NULL,
-            GetContentSettingValue(
-                &provider, primary_url, primary_url,
-                CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSettingValue(&provider,
+                                   primary_url,
+                                   primary_url,
+                                   CONTENT_SETTINGS_TYPE_IMAGES,
+                                   std::string(),
+                                   false));
   provider.ShutdownOnUIThread();
 }
 
 TEST_F(PrefProviderTest, Patterns) {
   TestingProfile testing_profile;
   PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
                                               false);
 
   GURL host1("http://example.com/");
   GURL host2("http://www.example.com/");
   GURL host3("http://example.org/");
   GURL host4("file:///tmp/test.html");
   ContentSettingsPattern pattern1 =
       ContentSettingsPattern::FromString("[*.]example.com");
   ContentSettingsPattern pattern2 =
       ContentSettingsPattern::FromString("example.org");
   ContentSettingsPattern pattern3 =
       ContentSettingsPattern::FromString("file:///tmp/test.html");
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host1, host1, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host1,
+                              host1,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   pref_content_settings_provider.SetWebsiteSetting(
       pattern1,
       pattern1,
       CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
+      std::string(),
       Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host1, host1, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host1,
+                              host1,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host2, host2, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host2,
+                              host2,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host3, host3, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host3,
+                              host3,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
   pref_content_settings_provider.SetWebsiteSetting(
       pattern2,
       pattern2,
       CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
+      std::string(),
       Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host3, host3, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host3,
+                              host3,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
 
   EXPECT_EQ(CONTENT_SETTING_DEFAULT,
             GetContentSetting(&pref_content_settings_provider,
-                              host4, host4, CONTENT_SETTINGS_TYPE_IMAGES, "",
+                              host4,
+                              host4,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
                               false));
   pref_content_settings_provider.SetWebsiteSetting(
       pattern3,
       pattern3,
       CONTENT_SETTINGS_TYPE_IMAGES,
-      "",
+      std::string(),
       Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
-            GetContentSetting(
-                &pref_content_settings_provider,
-                host4, host4, CONTENT_SETTINGS_TYPE_IMAGES, "", false));
+            GetContentSetting(&pref_content_settings_provider,
+                              host4,
+                              host4,
+                              CONTENT_SETTINGS_TYPE_IMAGES,
+                              std::string(),
+                              false));
 
   pref_content_settings_provider.ShutdownOnUIThread();
 }
 
 TEST_F(PrefProviderTest, ResourceIdentifier) {
   TestingProfile testing_profile;
   PrefProvider pref_content_settings_provider(testing_profile.GetPrefs(),
                                               false);
 
   GURL host("http://example.com/");
@@ skipping 79 matching lines @@
     DictionaryValue* mutable_settings = update.Get();
     mutable_settings->SetWithoutPathExpansion("www.example.com,*",
                                               new base::DictionaryValue());
   }
   EXPECT_TRUE(observer.notification_received());
 
   provider.ShutdownOnUIThread();
 }
 
 }  // namespace content_settings