Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: components/suggestions/suggestions_service.h

Issue 1314493013: Popular sites on the NTP: add thumbnails! (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/suggestions/suggestions_service.h
diff --git a/components/suggestions/suggestions_service.h b/components/suggestions/suggestions_service.h
index 7f0aab3525adaa6cd9cefb2e16db3910f763b57c..1dc66a033f3cc775cad4fce2fb64e077bb549eeb 100644
--- a/components/suggestions/suggestions_service.h
+++ b/components/suggestions/suggestions_service.h
@@ -75,6 +75,14 @@ class SuggestionsService : public KeyedService, public net::URLFetcherDelegate {
const GURL& url,
base::Callback<void(const GURL&, const SkBitmap*)> callback);
+ // A version of |GetPageThumbnail| that explicitly supplies the download URL
+ // for the thumbnail. Replaces any pre-existing thumbnail URL with the
+ // supplied one.
+ void GetPageThumbnailWithURL(
+ const GURL& url,
+ const GURL& thumbnail_url,
+ base::Callback<void(const GURL&, const SkBitmap*)> callback);
Bernhard Bauer 2015/09/04 13:42:41 Pass the callback by const reference?
Marc Treib 2015/09/04 13:49:03 Done. I was just blindly copying GetPageThumbnail
+
// Adds a URL to the blacklist cache, invoking |callback| on success or
// |fail_callback| otherwise. The URL will eventually be uploaded to the
// server.

Powered by Google App Engine
This is Rietveld 408576698