Popular sites on the NTP: add thumbnails!

chrome/browser/android/most_visited_sites.cc

Index: chrome/browser/android/most_visited_sites.cc
diff --git a/chrome/browser/android/most_visited_sites.cc b/chrome/browser/android/most_visited_sites.cc
index 72733008c0f002c5f60635eeab19ebf028f4c220..f18c8f81c7366b57e0552c388d7a5da05d99d8e9 100644
--- a/chrome/browser/android/most_visited_sites.cc
+++ b/chrome/browser/android/most_visited_sites.cc
@@ -229,15 +229,31 @@ void MostVisitedSites::OnLocalThumbnailFetched(
     scoped_refptr<TopSites> top_sites(TopSitesFactory::GetForProfile(profile_));
     if (top_sites)
       top_sites->AddForcedURL(url, base::Time::Now());
+    // Also fetch a remote thumbnail if possible. PopularSites or the
+    // SuggestionsService can supply a thumbnail download URL.
     SuggestionsService* suggestions_service =
-        (mv_source_ == SUGGESTIONS_SERVICE)
-            ? SuggestionsServiceFactory::GetForProfile(profile_)
-            : nullptr;
+        SuggestionsServiceFactory::GetForProfile(profile_);
     if (suggestions_service) {
-      return suggestions_service->GetPageThumbnail(
-          url, base::Bind(&MostVisitedSites::OnObtainedThumbnail,
-                          weak_ptr_factory_.GetWeakPtr(), false,
-                          base::Passed(&j_callback)));
+      if (popular_sites_) {
+        const std::vector<PopularSites::Site>& sites = popular_sites_->sites();
+        auto it = std::find_if(sites.begin(), sites.end(),
+                               [&url](const PopularSites::Site& site) {
+                                 return site.url == url;
+                               });
+        if (it != sites.end() && it->thumbnail_url.is_valid()) {
+          return suggestions_service->GetPageThumbnailWithURL(

[Marc Treib, 2015/09/04 13:29:12]

I guess it's a bit hacky to go through the SuggestionsService here, even though
it might not be active. But it has all the thumbnail fetching logic set up
nicely. :)
The alternative would be to pull all of that out of components/suggestions and
put it somewhere else, probably a standalone component? That doesn't seem worth
the trouble, especially if we eventually want to move to ML.

+              url, it->thumbnail_url,
+              base::Bind(&MostVisitedSites::OnObtainedThumbnail,
+                         weak_ptr_factory_.GetWeakPtr(), false,
+                         base::Passed(&j_callback)));
+        }
+      }
+      if (mv_source_ == SUGGESTIONS_SERVICE) {
+        return suggestions_service->GetPageThumbnail(
+            url, base::Bind(&MostVisitedSites::OnObtainedThumbnail,
+                            weak_ptr_factory_.GetWeakPtr(), false,
+                            base::Passed(&j_callback)));
+      }
     }
   }
   OnObtainedThumbnail(true, j_callback.Pass(), url, bitmap.get());