Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1314493010: Never run errorprone on non-Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/host_jar.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 if (defined(invoker.chromium_code)) { 1026 if (defined(invoker.chromium_code)) {
1027 _chromium_code = invoker.chromium_code 1027 _chromium_code = invoker.chromium_code
1028 } 1028 }
1029 1029
1030 _supports_android = true 1030 _supports_android = true
1031 if (defined(invoker.supports_android)) { 1031 if (defined(invoker.supports_android)) {
1032 _supports_android = invoker.supports_android 1032 _supports_android = invoker.supports_android
1033 } 1033 }
1034 1034
1035 _enable_errorprone = use_errorprone_java_compiler 1035 _enable_errorprone = use_errorprone_java_compiler
1036 if (defined(invoker.enable_errorprone)) { 1036 if (!_chromium_code) {
1037 _enable_errorprone = false
1038 } else if (defined(invoker.enable_errorprone)) {
1037 _enable_errorprone = invoker.enable_errorprone 1039 _enable_errorprone = invoker.enable_errorprone
1038 } 1040 }
1039 1041
1040 _manifest_entries = [] 1042 _manifest_entries = []
1041 if (defined(invoker.manifest_entries)) { 1043 if (defined(invoker.manifest_entries)) {
1042 _manifest_entries = invoker.manifest_entries 1044 _manifest_entries = invoker.manifest_entries
1043 } 1045 }
1044 1046
1045 _srcjar_deps = [] 1047 _srcjar_deps = []
1046 if (defined(invoker.srcjar_deps)) { 1048 if (defined(invoker.srcjar_deps)) {
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1615 ] 1617 ]
1616 args = [ 1618 args = [
1617 "--depfile", 1619 "--depfile",
1618 rebase_path(depfile, root_build_dir), 1620 rebase_path(depfile, root_build_dir),
1619 "--script-output-path", 1621 "--script-output-path",
1620 rebase_path(generated_script, root_build_dir), 1622 rebase_path(generated_script, root_build_dir),
1621 ] 1623 ]
1622 args += test_runner_args 1624 args += test_runner_args
1623 } 1625 }
1624 } 1626 }
OLDNEW
« no previous file with comments | « no previous file | build/host_jar.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698