Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1314493010: Never run errorprone on non-Chromium code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/host_jar.gypi » ('j') | build/host_jar.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 883 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 if (defined(invoker.chromium_code)) { 894 if (defined(invoker.chromium_code)) {
895 _chromium_code = invoker.chromium_code 895 _chromium_code = invoker.chromium_code
896 } 896 }
897 897
898 _supports_android = true 898 _supports_android = true
899 if (defined(invoker.supports_android)) { 899 if (defined(invoker.supports_android)) {
900 _supports_android = invoker.supports_android 900 _supports_android = invoker.supports_android
901 } 901 }
902 902
903 _enable_errorprone = use_errorprone_java_compiler 903 _enable_errorprone = use_errorprone_java_compiler
904 if (defined(invoker.enable_errorprone)) { 904 if (!_chromium_code) {
jbudorick 2015/08/27 16:53:49 GN is so much more sane.
905 _enable_errorprone = false
906 } else if (defined(invoker.enable_errorprone)) {
905 _enable_errorprone = invoker.enable_errorprone 907 _enable_errorprone = invoker.enable_errorprone
906 } 908 }
907 909
908 _manifest_entries = [] 910 _manifest_entries = []
909 if (defined(invoker.manifest_entries)) { 911 if (defined(invoker.manifest_entries)) {
910 _manifest_entries = invoker.manifest_entries 912 _manifest_entries = invoker.manifest_entries
911 } 913 }
912 914
913 _srcjar_deps = [] 915 _srcjar_deps = []
914 if (defined(invoker.srcjar_deps)) { 916 if (defined(invoker.srcjar_deps)) {
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
1502 ] 1504 ]
1503 args = [ 1505 args = [
1504 "--depfile", 1506 "--depfile",
1505 rebase_path(depfile, root_build_dir), 1507 rebase_path(depfile, root_build_dir),
1506 "--script-output-path", 1508 "--script-output-path",
1507 rebase_path(generated_script, root_build_dir), 1509 rebase_path(generated_script, root_build_dir),
1508 ] 1510 ]
1509 args += test_runner_args 1511 args += test_runner_args
1510 } 1512 }
1511 } 1513 }
OLDNEW
« no previous file with comments | « no previous file | build/host_jar.gypi » ('j') | build/host_jar.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698