Never run errorprone on non-Chromium code.

Never run errorprone on non-Chromium code.

If errorprone finds an error in non-Chromium code the build will
fail. This shouldn't happen, so I am disabling errorprone on
non-Chromium code.

BUG=

Committed: https://crrev.com/bb9e4863c7dd58c17fd53cd025f7f0dad17a52a5
Cr-Commit-Position: refs/heads/master@{#345941}

[mikecase (-- gone --), 2015-08-26 19:37:56]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2015-08-26 19:37:57]

Need some input on the gyp files. This appears to do what I want though.

[jbudorick, 2015-08-26 19:44:25]

https://codereview.chromium.org/1314493010/diff/1/build/host_jar.gypi
File build/host_jar.gypi (right):

https://codereview.chromium.org/1314493010/diff/1/build/host_jar.gypi#newcode58
build/host_jar.gypi:58: 'enable_errorprone': 0,
Really? This works?

[mikecase (-- gone --), 2015-08-26 20:16:51]

https://codereview.chromium.org/1314493010/diff/1/build/host_jar.gypi
File build/host_jar.gypi (right):

https://codereview.chromium.org/1314493010/diff/1/build/host_jar.gypi#newcode58
build/host_jar.gypi:58: 'enable_errorprone': 0,
On 2015/08/26 at 19:44:25, jbudorick wrote:
> Really? This works?

Just double checked. This will make enable_errorprone be 0 for targets with
chromium_code == 0.

[mikecase (-- gone --), 2015-08-27 16:52:41]

Just a quick ping, since when I land this I can enable errorprone on fyi
builder.

[jbudorick, 2015-08-27 16:53:49]

lgtm

https://codereview.chromium.org/1314493010/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1314493010/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:904: if (!_chromium_code) {
GN is so much more sane.

[mikecase (-- gone --), 2015-08-27 16:57:33]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-08-27 16:57:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314493010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314493010/1

[commit-bot: I haz the power, 2015-08-27 17:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 17:00:18]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mikecase (-- gone --), 2015-08-27 17:15:42]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-08-27 17:15:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1314493010/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-08-27 17:16:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314493010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314493010/20001

[commit-bot: I haz the power, 2015-08-27 18:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 18:04:18]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mikecase (-- gone --), 2015-08-27 18:15:10]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-08-27 18:15:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314493010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314493010/20001

[commit-bot: I haz the power, 2015-08-27 19:15:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-27 19:15:56]

Patchset 2 (id:??) landed as
https://crrev.com/bb9e4863c7dd58c17fd53cd025f7f0dad17a52a5
Cr-Commit-Position: refs/heads/master@{#345941}