Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314493006: Remove named load from builtin in default super call. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove named load from builtin in default super call. R=yangguo@chromium.org Committed: https://crrev.com/7f9685c3544ee563e8a5ed5ce4c6cb5d8e9a30fb Cr-Commit-Position: refs/heads/master@{#30389}

Patch Set 1 #

Patch Set 2 : Offline comment. #

Patch Set 3 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M src/parser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-26 11:15:22 UTC) #1
Michael Starzinger
Addressed offline comment. PTAL.
5 years, 3 months ago (2015-08-26 14:21:24 UTC) #2
Yang
On 2015/08/26 14:21:24, Michael Starzinger wrote: > Addressed offline comment. PTAL. LGTM. Please update comment ...
5 years, 3 months ago (2015-08-26 14:25:16 UTC) #3
Michael Starzinger
Addressed comment. Also in Parser::SpreadCall. Landing.
5 years, 3 months ago (2015-08-26 15:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314493006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314493006/40001
5 years, 3 months ago (2015-08-26 15:11:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-26 15:33:29 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 15:33:47 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7f9685c3544ee563e8a5ed5ce4c6cb5d8e9a30fb
Cr-Commit-Position: refs/heads/master@{#30389}

Powered by Google App Engine
This is Rietveld 408576698