src/v8natives.js - Issue 1314493005: Remove unnecessary checks and runtime calls from ToLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 1314493005: Remove unnecessary checks and runtime calls from ToLength (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add NaN check Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index b051a044b4c532f835a2bdd16ee96c04d4236eab..2081d216079aaf7d5baa1de72f0bbfa0c1a4d264 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -1541,7 +1541,7 @@ function NumberIsSafeInteger(number) {

if (NumberIsFinite(number)) {

var integral = TO_INTEGER(number);

if (integral == number) {

- return MathAbs(integral) <= GlobalNumber.MAX_SAFE_INTEGER;

+ return MathAbs(integral) <= kMaxSafeInteger;

}

return false;

« src/runtime.js ('K') | « src/runtime.js ('k') | no next file » | no next file with comments »