Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1314493003: Implement most of WebUSB device client interface (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement most of WebUSB device client interface This wires up the WebUSB device client interface from content/renderer to the devices app. Bulk and interrupt transfer support remains unimplemented, pending changes to the underlying service interface. BUG=492204 R=reillyg@chromium.org Committed: https://crrev.com/3a5e7bccbe7dc0e6c58ebb60e840d13794ce5a7b Cr-Commit-Position: refs/heads/master@{#345208}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Patch Set 3 : allow null data on controlTransfer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -17 lines) Patch
M content/renderer/usb/web_usb_device_impl.cc View 1 2 5 chunks +220 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Rockot(use gerrit already)
please take a look!
5 years, 4 months ago (2015-08-24 20:19:54 UTC) #1
Reilly Grant (use Gerrit)
This patch should be updated to match the details I've added to the spec recently ...
5 years, 4 months ago (2015-08-24 21:24:15 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1314493003/diff/1/content/renderer/usb/web_usb_device_impl.cc File content/renderer/usb/web_usb_device_impl.cc (right): https://codereview.chromium.org/1314493003/diff/1/content/renderer/usb/web_usb_device_impl.cc#newcode121 content/renderer/usb/web_usb_device_impl.cc:121: scoped_ptr<blink::WebUSBTransferInfo> info(new blink::WebUSBTransferInfo); On 2015/08/24 21:24:15, Reilly Grant wrote: ...
5 years, 4 months ago (2015-08-24 21:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314493003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314493003/40001
5 years, 4 months ago (2015-08-24 22:54:02 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-24 23:39:40 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 23:40:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a5e7bccbe7dc0e6c58ebb60e840d13794ce5a7b
Cr-Commit-Position: refs/heads/master@{#345208}

Powered by Google App Engine
This is Rietveld 408576698