Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1314483006: Revert of Make SkGraphics::Term a no-op, stop calling it. (Closed)

Created:
5 years, 3 months ago by mtklein
Modified:
5 years, 3 months ago
Reviewers:
scroggo, mtklein_C, reed1
CC:
reviews_skia.org, scroggo
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make SkGraphics::Term a no-op, stop calling it. (patchset #2 id:20001 of https://codereview.chromium.org/1329853005/ ) Reason for revert: SK_ATTR_DEPRECATED is meaningful to Android. Don't use it. Original issue's description: > Make SkGraphics::Term a no-op, stop calling it. > > I'd remove it entirely but Android is calling it explicitly. > > BUG=skia:4259 > > Committed: https://skia.googlesource.com/skia/+/925979f733fe8e70d84627147dee04d030423349 TBR=reed@google.com,scroggo@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4259 Committed: https://skia.googlesource.com/skia/+/d9b8d7ac1fb4628f3411253c0fc6cd37e4ff0487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M debugger/debuggermain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M example/HelloWorld.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/SimpleCocoaApp/SimpleApp.mm View 6 chunks +8 lines, -7 lines 0 comments Download
M experimental/SimpleiOSApp/SimpleApp.mm View 3 chunks +2 lines, -8 lines 0 comments Download
M experimental/SkV8Example/SkV8Example.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkGraphics.h View 2 chunks +7 lines, -2 lines 0 comments Download
M include/core/SkPaint.h View 3 chunks +4 lines, -1 line 0 comments Download
M include/views/SkEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/filtermain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/iOSShell.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Make SkGraphics::Term a no-op, stop calling it.
5 years, 3 months ago (2015-09-09 14:21:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314483006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314483006/1
5 years, 3 months ago (2015-09-09 14:22:03 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 14:22:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9b8d7ac1fb4628f3411253c0fc6cd37e4ff0487

Powered by Google App Engine
This is Rietveld 408576698