test/cctest/compiler/test-run-stubs.cc - Issue 1314473007: [turbofan] Remove usage of Unique<T> from graph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-run-stubs.cc

Issue 1314473007: [turbofan] Remove usage of Unique<T> from graph. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebased and fixed. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/test-run-stubs.cc

diff --git a/test/cctest/compiler/test-run-stubs.cc b/test/cctest/compiler/test-run-stubs.cc

index 607efa135b9cc1975e680d5d9a15b4ff74a32c64..ca7155f5cfd78673f8613ab4597745ced394ff44 100644

--- a/test/cctest/compiler/test-run-stubs.cc

+++ b/test/cctest/compiler/test-run-stubs.cc

@@ -41,10 +41,8 @@ TEST(RunOptimizedMathFloorStub) {

Node* start = graph.NewNode(common.Start(4));

// Parameter 0 is the number to round

Node* numberParam = graph.NewNode(common.Parameter(1), start);

- Unique<HeapObject> u = Unique<HeapObject>::CreateImmovable(code);

- Node* theCode = graph.NewNode(common.HeapConstant(u));

- Unique<HeapObject> tvu = Unique<HeapObject>::CreateImmovable(tv);

- Node* vector = graph.NewNode(common.HeapConstant(tvu));

+ Node* theCode = graph.NewNode(common.HeapConstant(code));

+ Node* vector = graph.NewNode(common.HeapConstant(tv));

Node* dummyContext = graph.NewNode(common.NumberConstant(0.0));

Node* call =

graph.NewNode(common.Call(descriptor), theCode, js.UndefinedConstant(),

@@ -83,8 +81,7 @@ TEST(RunStringLengthTFStub) {

Node* nameParam = graph.NewNode(common.Parameter(2), start);

Node* slotParam = graph.NewNode(common.Parameter(3), start);

Node* vectorParam = graph.NewNode(common.Parameter(4), start);

- Unique<HeapObject> u = Unique<HeapObject>::CreateImmovable(code);

- Node* theCode = graph.NewNode(common.HeapConstant(u));

+ Node* theCode = graph.NewNode(common.HeapConstant(code));

Node* dummyContext = graph.NewNode(common.NumberConstant(0.0));

Node* call =

graph.NewNode(common.Call(descriptor), theCode, receiverParam, nameParam,

@@ -127,8 +124,7 @@ TEST(RunStringAddTFStub) {

// Parameter 0 is the receiver

Node* leftParam = graph.NewNode(common.Parameter(1), start);

Node* rightParam = graph.NewNode(common.Parameter(2), start);

- Unique<HeapObject> u = Unique<HeapObject>::CreateImmovable(code);

- Node* theCode = graph.NewNode(common.HeapConstant(u));

+ Node* theCode = graph.NewNode(common.HeapConstant(code));

Node* dummyContext = graph.NewNode(common.NumberConstant(0.0));

Node* call = graph.NewNode(common.Call(descriptor), theCode, leftParam,

rightParam, dummyContext, start, start);

« no previous file with comments | « test/cctest/compiler/test-run-native-calls.cc ('k') | test/cctest/compiler/value-helper.h » ('j') | no next file with comments »