Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1314443003: idl_parser: An error should be reduced to DictionaryMembers (Closed)

Created:
5 years, 4 months ago by bashi
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, shimadaa, natsukoa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

idl_parser: An error should be reduced to DictionaryMembers To propage errors while parsing DictionaryMembers. Otherwise, the parser goes into an infinite loop. BUG=524353 Committed: https://crrev.com/791e27c637f2b74e048404e25bb08a29c1364d38 Cr-Commit-Position: refs/heads/master@{#345294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tools/idl_parser/idl_parser.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/dictionary_web.idl View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
Haraken-san, PTAL? shimadaa@, natsukoa@: FYI
5 years, 4 months ago (2015-08-25 09:01:16 UTC) #2
haraken
LGTM, thanks for the quick fix!
5 years, 4 months ago (2015-08-25 09:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314443003/1
5 years, 4 months ago (2015-08-25 09:15:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 10:00:17 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:01:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/791e27c637f2b74e048404e25bb08a29c1364d38
Cr-Commit-Position: refs/heads/master@{#345294}

Powered by Google App Engine
This is Rietveld 408576698