Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314433011: Introduce visiblePositionOf() for Position and PositionInComposedTree (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, yoichio, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce visiblePositionOf() for Position and PositionInComposedTree This patch introduces |visiblePositionOf()| for |Position| and |PositionInComposedTree| as preparation of templatizing |VisiblePosition| to make |VisiblePosition| not to use |PositionInComposedTree| for introducing composed tree version of |VisiblePosition|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201477

Patch Set 1 : 2015-08-31T16:32:26 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -41 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SelectionController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 4 chunks +14 lines, -4 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +31 lines, -22 lines 0 comments Download
M Source/core/editing/VisiblePositionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 08:03:05 UTC) #2
tkent
rs lgtm
5 years, 3 months ago (2015-08-31 08:15:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314433011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314433011/1
5 years, 3 months ago (2015-08-31 08:17:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314433011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314433011/1
5 years, 3 months ago (2015-08-31 09:01:40 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 10:06:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201477

Powered by Google App Engine
This is Rietveld 408576698