Issue 131443005: Fix d8 DebugMessageDetails and DebugCommandToJSONRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131443005: Fix d8 DebugMessageDetails and DebugCommandToJSONRequest (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix d8 DebugMessageDetails and DebugCommandToJSONRequest They both returned zapped handles. Use an EscapableHandleScope and properly return handles BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18517

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	src/d8.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/d8.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-09 13:57:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18517 (presubmit successful).