Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1314423006: Revert "Revert of [turbofan] greedy: heuristic for memory operands (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [turbofan] greedy: heuristic for memory operands (patchset #2 id:40001 of https://codereview.chromium.org/1306823005/ )" This reverts commit f68cd33bdd342819abd5b091591ac78383c2e79d. BUG= Committed: https://crrev.com/6009697eb22327a2b74f7153251c09ac6d042896 Cr-Commit-Position: refs/heads/master@{#30509}

Patch Set 1 #

Patch Set 2 : The Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/compiler/greedy-allocator.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-01 10:47:42 UTC) #2
Jarin
lgtm, although I do not fully understand why there is the call to FindOptimalSplitPos after ...
5 years, 3 months ago (2015-09-01 11:57:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314423006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314423006/20001
5 years, 3 months ago (2015-09-01 12:31:20 UTC) #5
Mircea Trofin
On 2015/09/01 11:57:32, Jarin wrote: > lgtm, although I do not fully understand why there ...
5 years, 3 months ago (2015-09-01 12:33:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 12:33:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 12:33:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6009697eb22327a2b74f7153251c09ac6d042896
Cr-Commit-Position: refs/heads/master@{#30509}

Powered by Google App Engine
This is Rietveld 408576698