content/browser/presentation/presentation_type_converters.h - Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/presentation/presentation_type_converters.h

Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Yuri's comments; rework of the OffscreenPresentationManager interface Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/presentation/presentation_service_impl.cc ('K') | « content/browser/presentation/presentation_service_impl.cc ('k') | content/common/presentation/presentation_service.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/presentation/presentation_type_converters.h

diff --git a/content/browser/presentation/presentation_type_converters.h b/content/browser/presentation/presentation_type_converters.h

index f66c3230aba0baffd31ff555ef897b8ddeea7d84..0d3fb2f445772297b97818f30c9032e461119b72 100644

--- a/content/browser/presentation/presentation_type_converters.h

+++ b/content/browser/presentation/presentation_type_converters.h

@@ -28,7 +28,8 @@ struct TypeConverter<presentation::PresentationSessionInfoPtr,

const content::PresentationSessionInfo& input) {

presentation::PresentationSessionInfoPtr output(

presentation::PresentationSessionInfo::New());

- output->url = input.presentation_url;

+ if (!input.presentation_url.empty())

+ output->url = input.presentation_url;

output->id = input.presentation_id;

return output.Pass();

}