Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: content/browser/presentation/presentation_type_converters.h

Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed yuri's comments #16 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_type_converters.h
diff --git a/content/browser/presentation/presentation_type_converters.h b/content/browser/presentation/presentation_type_converters.h
index f66c3230aba0baffd31ff555ef897b8ddeea7d84..0d3fb2f445772297b97818f30c9032e461119b72 100644
--- a/content/browser/presentation/presentation_type_converters.h
+++ b/content/browser/presentation/presentation_type_converters.h
@@ -28,7 +28,8 @@ struct TypeConverter<presentation::PresentationSessionInfoPtr,
const content::PresentationSessionInfo& input) {
presentation::PresentationSessionInfoPtr output(
presentation::PresentationSessionInfo::New());
- output->url = input.presentation_url;
+ if (!input.presentation_url.empty())
mark a. foltz 2015/10/12 21:56:10 What is creating a presentation with an empty URL?
whywhat 2015/10/13 15:21:31 the default value of output->url is empty anyway,
imcheng 2015/10/17 01:00:24 PresentationConnection objects in receiving contex
imcheng 2015/10/17 01:00:24 I believe it makes a difference in mojo. mojo::Str
+ output->url = input.presentation_url;
output->id = input.presentation_id;
return output.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698