[Presentation API] 1-UA presentation support + presenter APIs.

chrome/browser/media/router/media_router_type_converters.cc

Index: chrome/browser/media/router/media_router_type_converters.cc
diff --git a/chrome/browser/media/router/media_router_type_converters.cc b/chrome/browser/media/router/media_router_type_converters.cc
index a0e2aed8c8763ec64fc85999081c04a850d45eee..4403b04de9261956f71db1178875612b518d7f85 100644
--- a/chrome/browser/media/router/media_router_type_converters.cc
+++ b/chrome/browser/media/router/media_router_type_converters.cc
@@ -57,20 +57,24 @@ TypeConverter<media_router::MediaSink, MediaSinkPtr>::Convert(
 media_router::MediaRoute
 TypeConverter<media_router::MediaRoute, MediaRoutePtr>::Convert(
     const MediaRoutePtr& input) {
-  return media_router::MediaRoute(
+  media_router::MediaRoute route(
       input->media_route_id, media_router::MediaSource(input->media_source),
       input->media_sink_id, input->description, input->is_local,
       input->custom_controller_path, input->for_display);
+  route.set_is_offscreen_presentation(input->is_offscreen_presentation);

[whywhat, 2015/10/13 15:21:30]

nit: it feels like for consistency is_offscreen_presentation should just be
passed in the constructor like the rest of the parameters.

[imcheng, 2015/10/17 01:00:23]

The problem is the MediaRoute class is starting to have too many constructor
arguments. The constructor should take fewer arguments with fields set to
default values initially, which can then be modified with setters. This will
need to be fixed in a separate patch.
See Yuri's comment in an earlier PS.

+  return route;
 }
 
 // static
 scoped_ptr<media_router::MediaRoute>
 TypeConverter<scoped_ptr<media_router::MediaRoute>, MediaRoutePtr>::Convert(
     const MediaRoutePtr& input) {
-  return make_scoped_ptr(new media_router::MediaRoute(
+  scoped_ptr<media_router::MediaRoute> route(new media_router::MediaRoute(
       input->media_route_id, media_router::MediaSource(input->media_source),
       input->media_sink_id, input->description, input->is_local,
       input->custom_controller_path, input->for_display));
+  route->set_is_offscreen_presentation(input->is_offscreen_presentation);
+  return route.Pass();
 }
 
 media_router::Issue::Severity IssueSeverityFromMojo(