[Presentation API] 1-UA presentation support + presenter APIs.

chrome/browser/media/router/media_router_type_converters.cc

Index: chrome/browser/media/router/media_router_type_converters.cc
diff --git a/chrome/browser/media/router/media_router_type_converters.cc b/chrome/browser/media/router/media_router_type_converters.cc
index a0e2aed8c8763ec64fc85999081c04a850d45eee..4403b04de9261956f71db1178875612b518d7f85 100644
--- a/chrome/browser/media/router/media_router_type_converters.cc
+++ b/chrome/browser/media/router/media_router_type_converters.cc
@@ -57,20 +57,24 @@ TypeConverter<media_router::MediaSink, MediaSinkPtr>::Convert(
 media_router::MediaRoute
 TypeConverter<media_router::MediaRoute, MediaRoutePtr>::Convert(
     const MediaRoutePtr& input) {
-  return media_router::MediaRoute(
+  media_router::MediaRoute route(
       input->media_route_id, media_router::MediaSource(input->media_source),
       input->media_sink_id, input->description, input->is_local,
       input->custom_controller_path, input->for_display);
+  route.set_is_offscreen_presentation(input->is_offscreen_presentation);

[miu, 2015/10/07 21:51:46]

Unless I'm missing something, consider just defining a copy constructor in the
MediaRoute class.  Then, you wouldn't even need these two Convert() functions. 
It would be fine if this were a clean-up TODO for a later CL.

[imcheng, 2015/10/10 04:39:43]

These are template specializations for mojo type converters which is usually how
we convert from mojo types to "native" types, I think. I was also thinking that
by putting the converters here, we won't introduce mojo types into
media_route.{h,cc} so it's cleaner.

+  return route;
 }
 
 // static
 scoped_ptr<media_router::MediaRoute>
 TypeConverter<scoped_ptr<media_router::MediaRoute>, MediaRoutePtr>::Convert(
     const MediaRoutePtr& input) {
-  return make_scoped_ptr(new media_router::MediaRoute(
+  scoped_ptr<media_router::MediaRoute> route(new media_router::MediaRoute(
       input->media_route_id, media_router::MediaSource(input->media_source),
       input->media_sink_id, input->description, input->is_local,
       input->custom_controller_path, input->for_display));
+  route->set_is_offscreen_presentation(input->is_offscreen_presentation);
+  return route.Pass();
 }
 
 media_router::Issue::Severity IssueSeverityFromMojo(