chrome/browser/media/router/render_frame_host_helper.h - Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/router/render_frame_host_helper.h

Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed yuri's comments #16 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc ('K') | « chrome/browser/media/router/receiver_presentation_service_delegate_impl.cc ('k') | content/browser/presentation/presentation_service_impl.h » ('j') | content/browser/presentation/presentation_type_converters.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	mark a. foltz 2015/10/12 21:56:10 Maybe this should be named render_frame_host_id.h? Maybe this should be named render_frame_host_id.h? imcheng 2015/10/17 01:00:24 Done. Show quoted text On 2015/10/12 21:56:10, mark a. foltz wrote: > Maybe this should be named render_frame_host_id.h? Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

	6 #define CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

	7

	8 #include <utility>

	9

	10 #include "content/public/browser/render_frame_host.h"

	11 #include "content/public/browser/render_process_host.h"

	12

	13 namespace media_router {

	14

	15 using RenderFrameHostId =

	16 std::pair<decltype(((content::RenderProcessHost*)nullptr)->GetID()),
	mark a. foltz 2015/10/12 21:56:10 Is decltype necessary here? It seems to only be r Is decltype necessary here? It seems to only be recommended for rare situations like variadic templates. https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/_zoNvZd_dSo If the types of the ids get widened to long (which seems unlikely) you should get a compile error when trying to assign them to pair<int, int>. imcheng 2015/10/17 01:00:24 Done. Show quoted text On 2015/10/12 21:56:10, mark a. foltz wrote: > Is decltype necessary here? It seems to only be recommended for rare situations > like variadic templates. > > https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/_zoNvZd_dSo > > If the types of the ids get widened to long (which seems unlikely) you should > get a compile error when trying to assign them to pair<int, int>. > Done.
	17 decltype(((content::RenderFrameHost*)nullptr)->GetRoutingID())>;

	18

	19 } // namespace media_router

	20

	21 #endif // CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

OLD	NEW