chrome/browser/media/router/render_frame_host_helper.h - Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/router/render_frame_host_helper.h

Issue 1314413005: [Presentation API] 1-UA presentation support + presenter APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/media/router/presentation_service_delegate_impl.h ('K') | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/ui/webui/media_router/media_router_ui.h » ('j') | content/public/browser/presentation_service_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

	6 #define CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

	7

	8 #include <utility>

	9

	10 namespace media_router {

	11

	12 using RenderFrameHostId = std::pair<int, int>;
	miu 2015/09/17 00:09:20 nit: Although they're likely always to be int's, i nit: Although they're likely always to be int's, it is documentative to define this as: using RenderFrameHostId = std::pair<decltype(content::RenderProcessHost::GetID()), decltype(content::RenderFrameHost::GetRoutingID())>; imcheng 2015/09/26 01:21:57 Done. Since these are member functions it ends up Show quoted text On 2015/09/17 00:09:20, miu wrote: > nit: Although they're likely always to be int's, it is documentative to define > this as: > > using RenderFrameHostId = > std::pair<decltype(content::RenderProcessHost::GetID()), > decltype(content::RenderFrameHost::GetRoutingID())>; Done. Since these are member functions it ends up being slightly more verbose but I think it's ok.
	13

	14 } // namespace media_router

	15

	16 #endif // CHROME_BROWSER_MEDIA_ROUTER_RENDER_FRAME_HOST_HELPER_H_

OLD	NEW