Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1314413002: Update CT documentation on Skia site. (Closed)

Created:
5 years, 3 months ago by dogben
Modified:
5 years, 3 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update CT documentation on Skia site. BUG=skia:4063 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1314413002 Committed: https://skia.googlesource.com/skia/+/fd0eca2583cca2b13a241af753d8e689cb3b4b54

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Updated 900k to 910k. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M site/dev/testing/ct.md View 1 3 chunks +12 lines, -13 lines 0 comments Download
D site/dev/testing/ct-system.png View Binary file 0 comments Download
A site/dev/testing/ct-system-diagram.svg View 1 chunk +4 lines, -0 lines 0 comments Download
A site/dev/testing/ct-system-diagram.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dogben
Preview at: https://x20web.corp.google.com/~benjaminwagner/no_crawl/ct.html
5 years, 3 months ago (2015-08-27 21:27:13 UTC) #5
rmistry
lgtm https://codereview.chromium.org/1314413002/diff/60001/site/dev/testing/ct-system-diagram.txt File site/dev/testing/ct-system-diagram.txt (right): https://codereview.chromium.org/1314413002/diff/60001/site/dev/testing/ct-system-diagram.txt#newcode2 site/dev/testing/ct-system-diagram.txt:2: https://docs.google.com/a/google.com/drawings/d/1q6NuBx5fZ_KwgiBcx_dK0cfwpEQJdypBrIPoTrGrlF4/edit?usp=sharing Why do we need this file? the ...
5 years, 3 months ago (2015-08-28 12:32:22 UTC) #6
dogben
https://codereview.chromium.org/1314413002/diff/60001/site/dev/testing/ct-system-diagram.txt File site/dev/testing/ct-system-diagram.txt (right): https://codereview.chromium.org/1314413002/diff/60001/site/dev/testing/ct-system-diagram.txt#newcode2 site/dev/testing/ct-system-diagram.txt:2: https://docs.google.com/a/google.com/drawings/d/1q6NuBx5fZ_KwgiBcx_dK0cfwpEQJdypBrIPoTrGrlF4/edit?usp=sharing On 2015/08/28 12:32:22, rmistry wrote: > Why do ...
5 years, 3 months ago (2015-08-28 17:17:00 UTC) #7
rmistry
lgtm
5 years, 3 months ago (2015-08-28 17:30:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314413002/80001
5 years, 3 months ago (2015-08-28 17:34:12 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 17:34:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/fd0eca2583cca2b13a241af753d8e689cb3b4b54

Powered by Google App Engine
This is Rietveld 408576698