Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1314393003: DevTools: Opened screenshot view is seen chopped in "Summery" section of Timeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 2a34fddac5bca24c132a41cde53e10f9340d7895..0eb3d79a33023d6da92f23f093415675f3e7281e 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -1456,7 +1456,7 @@ WebInspector.TimelineUIUtils.generateDetailsContentForFrame = function(frameMode
var filmStripPreview = createElementWithClass("img", "timeline-filmstrip-preview");
filmStripFrame.imageDataPromise().then(onGotImageData.bind(null, filmStripPreview));
contentHelper.appendElementRow(WebInspector.UIString("Screenshot"), filmStripPreview);
- filmStripPreview.addEventListener("click", filmStripClicked.bind(null, filmStripFrame), false);
+ filmStripPreview.addEventListener("click", frameClicked.bind(null, filmStripFrame), false);
}
var durationInMillis = frame.endTime - frame.startTime;
contentHelper.appendTextRow(WebInspector.UIString("FPS"), Math.floor(1000 / durationInMillis));
@@ -1480,9 +1480,9 @@ WebInspector.TimelineUIUtils.generateDetailsContentForFrame = function(frameMode
/**
* @param {!WebInspector.FilmStripModel.Frame} filmStripFrame
*/
- function filmStripClicked(filmStripFrame)
+ function frameClicked(filmStripFrame)
{
- WebInspector.Dialog.show(null, new WebInspector.FilmStripView.DialogDelegate(filmStripFrame, 0));
+ new WebInspector.FilmStripView.DialogDelegate(filmStripFrame, 0);
}
return contentHelper.element;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698