Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1314353004: Fix 3 more leaks in WebPluginContainerTests. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix 3 more leaks in WebPluginContainerTests. I missed LocalToWindowPointTest in https://codereview.chromium.org/1308663004/, and there are two more tests with different subclasses too. BUG=523910 TBR=chrishtr Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201521

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/web/tests/WebPluginContainerTest.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Since this is morally the same change as https://codereview.chromium.org/1308663004/ and since the leak bot I'm ...
5 years, 3 months ago (2015-09-01 04:32:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314353004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314353004/20001
5 years, 3 months ago (2015-09-01 04:32:30 UTC) #4
Nico
Committed patchset #2 (id:20001) manually as 201521 (presubmit successful).
5 years, 3 months ago (2015-09-01 05:22:07 UTC) #5
chrishtr
5 years, 3 months ago (2015-09-01 18:06:43 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698