Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314353002: Inline CSSCounterValue::listStyle() (Closed)

Created:
5 years, 3 months ago by sashab
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@clean_up_get_string_value
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Inline CSSCounterValue::listStyle() Inline CSSCounterValue::listStyle in CSSCounterValue::customCSSText() where it's used, and renamed listStyleIdent() to just listStyle(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201542

Patch Set 1 #

Total comments: 2

Patch Set 2 : Small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M Source/core/css/CSSCounterValue.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/CSSCounterValue.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1307673003 Patch 80001

Messages

Total messages: 14 (6 generated)
sashab
A follow-on from crrev.com/1307673003.
5 years, 3 months ago (2015-08-27 06:58:18 UTC) #2
Timothy Loh
https://codereview.chromium.org/1314353002/diff/1/Source/core/css/CSSCounterValue.cpp File Source/core/css/CSSCounterValue.cpp (right): https://codereview.chromium.org/1314353002/diff/1/Source/core/css/CSSCounterValue.cpp#newcode27 Source/core/css/CSSCounterValue.cpp:27: if (!m_listStyle->cssText().isEmpty() && !isDefaultListStyle) { it's never empty :S
5 years, 3 months ago (2015-08-27 07:18:41 UTC) #3
sashab
https://codereview.chromium.org/1314353002/diff/1/Source/core/css/CSSCounterValue.cpp File Source/core/css/CSSCounterValue.cpp (right): https://codereview.chromium.org/1314353002/diff/1/Source/core/css/CSSCounterValue.cpp#newcode27 Source/core/css/CSSCounterValue.cpp:27: if (!m_listStyle->cssText().isEmpty() && !isDefaultListStyle) { On 2015/08/27 07:18:41, Timothy ...
5 years, 3 months ago (2015-08-28 00:50:30 UTC) #4
Timothy Loh
lgtm
5 years, 3 months ago (2015-08-28 00:55:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314353002/20001
5 years, 3 months ago (2015-09-01 05:31:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/106275)
5 years, 3 months ago (2015-09-01 07:20:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314353002/20001
5 years, 3 months ago (2015-09-01 07:25:12 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:18:03 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201542

Powered by Google App Engine
This is Rietveld 408576698