Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1314333002: [Fetch API] Fix ScriptState leak in Fetch API unittests. (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch API] Fix ScriptState leak in Fetch API unittests. This CL fixes memory leaks caused by not calling disposePerContextData on ScriptState. BUG=524875 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yhirano
5 years, 3 months ago (2015-08-27 06:05:13 UTC) #2
haraken
The change looks ok, but can we probably use ScriptStateForTesting instead? It will take care ...
5 years, 3 months ago (2015-08-27 06:11:14 UTC) #3
yhirano
On 2015/08/27 06:11:14, haraken wrote: > The change looks ok, but can we probably use ...
5 years, 3 months ago (2015-08-27 06:59:21 UTC) #4
haraken
On 2015/08/27 06:59:21, yhirano wrote: > On 2015/08/27 06:11:14, haraken wrote: > > The change ...
5 years, 3 months ago (2015-08-27 08:53:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314333002/1
5 years, 3 months ago (2015-08-27 08:58:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 09:02:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201299

Powered by Google App Engine
This is Rietveld 408576698