Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 131433004: Don't initialize GL again in AcceleratedSurface::Initialize() (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, piman+watch_chromium.org, ccameron, jbauman
Visibility:
Public.

Description

Don't initialize GL again in AcceleratedSurface::Initialize() GL is initialized in content::SupportsCoreAnimationPlugins() so initializing it again hits DCHECKs and breaks things. Depend on the initialization to occur in SupportsCoreAnimationPlugins() only, and ensure that it only happens there once. R=piman BUG=340954 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250316

Patch Set 1 #

Patch Set 2 : macgl: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/child/npapi/plugin_host.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/surface/accelerated_surface_mac.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
6 years, 10 months ago (2014-02-10 16:57:36 UTC) #1
danakj
Eh, this isn't quite right. I think this will kill 3d in NPAPI plugins. We ...
6 years, 10 months ago (2014-02-10 19:00:02 UTC) #2
piman
lgtm
6 years, 10 months ago (2014-02-10 23:24:25 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-11 00:12:08 UTC) #4
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 10 months ago (2014-02-11 00:12:27 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-11 00:13:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/131433004/90001
6 years, 10 months ago (2014-02-11 00:18:09 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 03:46:55 UTC) #8
Message was sent while issue was closed.
Change committed as 250316

Powered by Google App Engine
This is Rietveld 408576698