Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1314273004: Reland of Allow direct and indirect navigation values to be varied via field trial. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
dominickn, benwells, gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Allow direct and indirect navigation values to be varied via field trial. (patchset #1 id:1 of https://codereview.chromium.org/1322503002/ ) Reason for revert: The revert didn't help. Original issue's description: > Revert of Allow direct and indirect navigation values to be varied via field trial. (patchset #3 id:60001 of https://codereview.chromium.org/1309803005/ ) > > Reason for revert: > Looks like this broke org.chromium.chrome.browser.banners.AppBannerManagerTest : http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29822 > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/21895 > > Original issue's description: > > Allow direct and indirect navigation values to be varied via field trial. > > > > This CL allows the engagement scores assigned to direct and indirect > > navigations to be varied via a field trial. It also makes method names > > related to the setting of values in AppBannerSettingsHelper more > > consistent. > > > > BUG=487519 > > > > Committed: https://crrev.com/633bbe04d2525d7272a78d78f8e3fdd0abe4d5a2 > > Cr-Commit-Position: refs/heads/master@{#345729} > > TBR=benwells@chromium.org,dfalcantara@chromium.org,dominickn@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=487519 > > Committed: https://crrev.com/22586e128b6861c2674025a836998e9ef59db51c > Cr-Commit-Position: refs/heads/master@{#345793} TBR=benwells@chromium.org,dfalcantara@chromium.org,dominickn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487519 Committed: https://crrev.com/23a2e942e6bcd0797761ad0e2f0a2be4f32ce238 Cr-Commit-Position: refs/heads/master@{#345811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_settings_helper.cc View 4 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Reland of Allow direct and indirect navigation values to be varied via field trial.
5 years, 3 months ago (2015-08-27 06:27:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314273004/1
5 years, 3 months ago (2015-08-27 06:27:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 06:28:06 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 06:28:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23a2e942e6bcd0797761ad0e2f0a2be4f32ce238
Cr-Commit-Position: refs/heads/master@{#345811}

Powered by Google App Engine
This is Rietveld 408576698