Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1314263002: PPC: Correctify instanceof and make it optimizable. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Correctify instanceof and make it optimizable. Port 5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc Original commit message: The previous hack with HInstanceOfKnownGlobal was not only slower, but also very brittle and required a lot of weird hacks to support it. And what's even more important it wasn't even correct (because a map check on the lhs is never enough for instanceof). The new implementation provides a sane runtime implementation for InstanceOf plus a fast case in the InstanceOfStub, combined with a proper specialization in the case of a known global in CrankShaft, which does only the prototype chain walk (coupled with a code dependency on the known global). As a drive-by-fix: Also fix the incorrect Object.prototype.isPrototypeOf implementation. R=bmeurer@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG=v8:4376 LOG=n Committed: https://crrev.com/448a3c0fe0f0d7b412bec455153b6b30e9aa803c Cr-Commit-Position: refs/heads/master@{#30419}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -618 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +102 lines, -203 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +36 lines, -144 lines 0 comments Download
M src/ppc/lithium-ppc.h View 3 chunks +13 lines, -29 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 2 chunks +10 lines, -16 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 3 chunks +1 line, -208 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MTBrandyberry
5 years, 3 months ago (2015-08-26 22:50:55 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-08-27 13:37:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314263002/1
5 years, 3 months ago (2015-08-27 13:42:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/7417) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-08-27 13:43:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314263002/1
5 years, 3 months ago (2015-08-27 14:31:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/7424) v8_linux64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-08-27 14:32:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314263002/20001
5 years, 3 months ago (2015-08-27 14:44:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 15:10:58 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 15:11:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/448a3c0fe0f0d7b412bec455153b6b30e9aa803c
Cr-Commit-Position: refs/heads/master@{#30419}

Powered by Google App Engine
This is Rietveld 408576698